Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on python dispatcher for EdgeOpArgValidator #3809

Closed
wants to merge 1 commit into from

Conversation

angelayi
Copy link
Contributor

@angelayi angelayi commented Jun 3, 2024

Summary:
Possibly fixes #3659

We need to enable the python dispatcher so that expand_copy and view_copy will go through the correct meta kernels

Differential Revision: D58091304

Copy link

pytorch-bot bot commented Jun 3, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3809

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7e2b4fa with merge base 13ba3a7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Summary:

Possibly fixes pytorch#3659

We need to enable the python dispatcher so that expand_copy and view_copy will go through the correct meta kernels

Differential Revision: D58091304
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Jun 3, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58091304

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58091304

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ab6f177.

@mergennachin
Copy link
Contributor

@pytorchbot cherry-pick --onto release/0.2 -c critical

pytorchbot pushed a commit that referenced this pull request Jun 3, 2024
Summary:
Pull Request resolved: #3809

Possibly fixes #3659

We need to enable the python dispatcher so that expand_copy and view_copy will go through the correct meta kernels

Reviewed By: larryliu0820

Differential Revision: D58091304

fbshipit-source-id: f8907ee130720b01c629d55f222eb5a7e63a34bd
(cherry picked from commit ab6f177)
@pytorchbot
Copy link
Collaborator

Cherry picking #3809

The cherry pick PR is at #3814 and it is recommended to link a critical cherry pick PR with an issue

Details for Dev Infra team Raised by workflow job

angelayi added a commit that referenced this pull request Jun 3, 2024
Summary:
Pull Request resolved: #3809

Possibly fixes #3659

We need to enable the python dispatcher so that expand_copy and view_copy will go through the correct meta kernels

Reviewed By: larryliu0820

Differential Revision: D58091304

fbshipit-source-id: f8907ee130720b01c629d55f222eb5a7e63a34bd
(cherry picked from commit ab6f177)
@angelayi angelayi mentioned this pull request Jun 3, 2024
angelayi added a commit that referenced this pull request Jun 3, 2024
Summary:
Pull Request resolved: #3809

Possibly fixes #3659

We need to enable the python dispatcher so that expand_copy and view_copy will go through the correct meta kernels

Reviewed By: larryliu0820

Differential Revision: D58091304

fbshipit-source-id: f8907ee130720b01c629d55f222eb5a7e63a34bd
(cherry picked from commit ab6f177)
angelayi added a commit that referenced this pull request Jun 3, 2024
Summary:
Pull Request resolved: #3809

Possibly fixes #3659

We need to enable the python dispatcher so that expand_copy and view_copy will go through the correct meta kernels

Reviewed By: larryliu0820

Differential Revision: D58091304

fbshipit-source-id: f8907ee130720b01c629d55f222eb5a7e63a34bd
(cherry picked from commit ab6f177)
Gasoonjia pushed a commit that referenced this pull request Jun 3, 2024
Summary:
Pull Request resolved: #3809

Possibly fixes #3659

We need to enable the python dispatcher so that expand_copy and view_copy will go through the correct meta kernels

Reviewed By: larryliu0820

Differential Revision: D58091304

fbshipit-source-id: f8907ee130720b01c629d55f222eb5a7e63a34bd
(cherry picked from commit ab6f177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors when lowering to edge.
5 participants