Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ArmTester logging #5629

Closed
wants to merge 2 commits into from

Conversation

Erik-Lundell
Copy link
Collaborator

See commits for description

Change-Id: I946e8487ad185d9994049ddcdcf7b08153c2597b
Signed-off-by: Erik Lundell <erik.lundell@arm.com>
- Dump operators/ dtypes in table or parseable format
- Use logger
- Format Graph Signature
- Clearer log messages in run_and_compare_methods

Change-Id: I0fb00545f8f4c2f443d7996279fdf7ef8b3ec2d6
Copy link

pytorch-bot bot commented Sep 25, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5629

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3d599ae with merge base d516309 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 25, 2024
@zingo zingo added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Sep 25, 2024
@zingo
Copy link
Collaborator

zingo commented Sep 25, 2024

@pytorchbot label ciflow/trunk

@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mergennachin merged this pull request in 0d96f75.

@Erik-Lundell Erik-Lundell deleted the save-tosa-dump branch October 3, 2024 09:20
@dvorjackz
Copy link
Contributor

Cherry picking this for the doc update, other changes seem localized enough to include as well.

@dvorjackz
Copy link
Contributor

@pytorchbot cherry-pick --onto release/0.4 -c docs

pytorchbot pushed a commit that referenced this pull request Oct 9, 2024
Summary:
See commits for description

Pull Request resolved: #5629

Reviewed By: digantdesai

Differential Revision: D63637272

Pulled By: mergennachin

fbshipit-source-id: c0025dcbe41b0e8c7c20252af4f31531d230712e
(cherry picked from commit 0d96f75)
@pytorchbot
Copy link
Collaborator

Cherry picking #5629

The cherry pick PR is at #6080 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

dvorjackz added a commit that referenced this pull request Oct 11, 2024
* Improve ArmTester logging (#5629)

Summary:
See commits for description

Pull Request resolved: #5629

Reviewed By: digantdesai

Differential Revision: D63637272

Pulled By: mergennachin

fbshipit-source-id: c0025dcbe41b0e8c7c20252af4f31531d230712e
(cherry picked from commit 0d96f75)

* Manually fix lint

---------

Co-authored-by: Erik Lundell <erik.lundell@arm.com>
Co-authored-by: Jack Zhang <dvorjackz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants