Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes for the demo app. #6064

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

pytorchbot
Copy link
Collaborator

Summary: .

Differential Revision: D64119638

Summary:
Pull Request resolved: #6051

.

Reviewed By: kirklandsign

Differential Revision: D64119638

fbshipit-source-id: 486e499d899625b397ddb32d6b0400e740804bae
(cherry picked from commit 9364c06)
Copy link

pytorch-bot bot commented Oct 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6064

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 86320e0 with merge base eecf74f (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2024
Copy link
Contributor

@dvorjackz dvorjackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the change in text_token_generator.h?

@shoumikhin
Copy link
Contributor

@d4l3k yes, it's needed to interrupt generation from UI in demo apps. Otherwise next time it tries to generate anything the token generator is already in a stopped state.

@shoumikhin shoumikhin merged commit f17c9e1 into release/0.4 Oct 11, 2024
7 of 8 checks passed
@shoumikhin shoumikhin deleted the cherry-pick-6051-by-pytorch_bot_bot_ branch October 11, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants