Script SinusoidalPositionalEmbedding #1612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D18924939 |
Differential Revision: D18925110 fbshipit-source-id: 1709620ba8f4a49d931101ecd209e90e5b46947d
Summary: Pull Request resolved: facebookresearch#1612 Make SinusoidalPositionalEmbedding scriptable. Mostly adding types. The only change that affects lots of downstream code is to have max_positions as member variable instead of method. Reviewed By: myleott Differential Revision: D18924939 fbshipit-source-id: d88dbad21f32d1445bfcd6e6f580ab8367b965da
cndn
added a commit
to cndn/translate
that referenced
this pull request
Jan 22, 2020
Summary: Pull Request resolved: facebookresearch/fairseq#1612 Make SinusoidalPositionalEmbedding scriptable. Mostly adding types. The only change that affects lots of downstream code is to have max_positions as member variable instead of method. Reviewed By: myleott Differential Revision: D18924939 fbshipit-source-id: 12fd5f1dd3f0f25a6a48e2d02a620279b59c954d
cndn
force-pushed
the
export-D18924939
branch
from
9d77c73
to
e758540
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18924939 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 22, 2020
Summary: Pull Request resolved: pytorch/translate#683 Pull Request resolved: #1612 Make SinusoidalPositionalEmbedding scriptable. Mostly adding types. The only change that affects lots of downstream code is to have max_positions as member variable instead of method. Reviewed By: myleott Differential Revision: D18924939 fbshipit-source-id: 2b6486563e9ec5cc34bcf11acdff9054658f4674
moussaKam
pushed a commit
to moussaKam/language-adaptive-pretraining
that referenced
this pull request
Sep 29, 2020
Summary: Pull Request resolved: pytorch/translate#683 Pull Request resolved: facebookresearch#1612 Make SinusoidalPositionalEmbedding scriptable. Mostly adding types. The only change that affects lots of downstream code is to have max_positions as member variable instead of method. Reviewed By: myleott Differential Revision: D18924939 fbshipit-source-id: 2b6486563e9ec5cc34bcf11acdff9054658f4674
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Make SinusoidalPositionalEmbedding scriptable. Mostly adding types. The only change that affects lots of downstream code is to have max_positions as member variable instead of method.
Differential Revision: D18924939