-
Notifications
You must be signed in to change notification settings - Fork 6.7k
addding polynomial lr scheduler #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d51fc2e to
7ddc0f4
Compare
Co-authored-by: jingfeidu <jingfeidu@fb.com>
7ddc0f4 to
d222b38
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ngoyal2707 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 22, 2020
Summary: Pull Request resolved: pytorch/translate#683 Pull Request resolved: #1612 Make SinusoidalPositionalEmbedding scriptable. Mostly adding types. The only change that affects lots of downstream code is to have max_positions as member variable instead of method. Reviewed By: myleott Differential Revision: D18924939 fbshipit-source-id: 2b6486563e9ec5cc34bcf11acdff9054658f4674
louismartin
pushed a commit
to louismartin/fairseq
that referenced
this pull request
Mar 24, 2020
Summary: Pull Request resolved: pytorch/translate#683 Pull Request resolved: facebookresearch#1612 Make SinusoidalPositionalEmbedding scriptable. Mostly adding types. The only change that affects lots of downstream code is to have max_positions as member variable instead of method. Reviewed By: myleott Differential Revision: D18924939 fbshipit-source-id: 2b6486563e9ec5cc34bcf11acdff9054658f4674
moussaKam
pushed a commit
to moussaKam/language-adaptive-pretraining
that referenced
this pull request
Sep 29, 2020
Summary: Pull Request resolved: pytorch/translate#683 Pull Request resolved: facebookresearch#1612 Make SinusoidalPositionalEmbedding scriptable. Mostly adding types. The only change that affects lots of downstream code is to have max_positions as member variable instead of method. Reviewed By: myleott Differential Revision: D18924939 fbshipit-source-id: 2b6486563e9ec5cc34bcf11acdff9054658f4674
yfyeung
pushed a commit
to yfyeung/fairseq
that referenced
this pull request
Dec 6, 2023
…arch#683) * init files * add ctc as auxiliary loss and ctc_decode.py * tuning the scalar of HLG score for 1best, nbest and nbest-oracle * rename to pruned_transducer_stateless7_ctc * fix doc * fix bug, recover the hlg scores * modify ctc_decode.py, move out the hlg scale * fix hlg_scale * add export.py and pretrained.py, and so on * upload files, update README.md and RESULTS.md * add CI test
Harleen8118
pushed a commit
to Harleen8118/IBERT
that referenced
this pull request
Jun 26, 2025
Summary: Co-authored-by: jingfeidu <jingfeidu@fb.com> The implementation is by Jingfei Du from branch "bigbert". Copied over to this CR to get it merged in isolation since other changes seem to be already in master. **Small changes from original:** Added following line in `__init__` as discovered by myleott : ``` self.optimizer.set_lr(self.warmup_factor * self.lr) ``` Pull Request resolved: facebookresearch/fairseq#683 Reviewed By: myleott Differential Revision: D15149628 Pulled By: myleott fbshipit-source-id: 5f715611182cdd111e636c66d5f24aa88fa03e29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: jingfeidu jingfeidu@fb.com
The implementation is by Jingfei Du from branch "bigbert". Copied over to this CR to get it merged in isolation since other changes seem to be already in master.
Small changes from original:
Added following line in
__init__as discovered by @myleott :