Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update calls to torch.hub.* to use trust_repo=True. #281

Merged
merged 6 commits into from
May 11, 2022
Merged

Update calls to torch.hub.* to use trust_repo=True. #281

merged 6 commits into from
May 11, 2022

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented May 10, 2022 •
edited
Loading

Follow up to pytorch/pytorch#72060, this PR updates the files with the use of trust_repo=True where necessary.

@netlify
Copy link

netlify bot commented May 10, 2022 •
edited
Loading

✅ Deploy Preview for pytorch-hub-preview ready!

Name Link
🔨 Latest commit 1f18e72
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-hub-preview/deploys/627b911408f286000e5acb49
😎 Deploy Preview https://deploy-preview-281--pytorch-hub-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

vmoens
vmoens approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusted!

@NicolasHug NicolasHug changed the title Try to see warnings in test logs Update calls to torch.hub.* to use trust_repo=True. May 11, 2022
@NicolasHug
Copy link
Member Author

Torchhub-related warnings disapeared in the previous commit so this is good to go! Thanks for the review @vmoens

@NicolasHug NicolasHug merged commit 5c690fa into pytorch:master May 11, 2022
@NicolasHug NicolasHug mentioned this pull request May 11, 2022
Open
@NicolasHug
Copy link
Member Author

Actually I'm not sure I should have merged this right now.
I don't remember if the torchhub website gets pushed nightly, or only when a new release is out.

If it's pushed nightly, we should revert it because the trust_repo=True won't be available until the next release. I'll check in the following days...

NicolasHug added a commit to NicolasHug/hub that referenced this pull request May 16, 2022
@NicolasHug
Revert "Update calls to torch.hub.* to use trust_repo=True. (pytorc…
6f29522 
…h#281)"

This reverts commit 5c690fa.
@NicolasHug
Copy link
Member Author

Yeah, I just checked this morning and I could see trust_repo=True on https://pytorch.org/hub/intelisl_midas_v2/, so the website is built nightly. I'll revert this and put it back once we're closer to the release.

@NicolasHug NicolasHug mentioned this pull request May 16, 2022
Merged
NicolasHug added a commit that referenced this pull request May 16, 2022
@NicolasHug
Revert "Update calls to torch.hub.* to use trust_repo=True. (#281)" (…
23d4266 
…#286)

This reverts commit 5c690fa.
@NicolasHug NicolasHug mentioned this pull request Jul 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @vmoens @facebook-github-bot