-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Minor] Fix typos #332
[Minor] Fix typos #332
Conversation
✅ Deploy Preview for pytorch-hub-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
#333 |
@vmoens can you review about this? |
scripts/install_deps.sh
Outdated
@@ -12,7 +12,8 @@ conda install -y regex pillow tqdm boto3 requests numpy h5py scipy matplotlib un | |||
conda install -y -c conda-forge librosa inflect | |||
|
|||
pip install -q fastBPE sacremoses sentencepiece subword_nmt editdistance | |||
pip install -q visdom mistune filelock tokenizers packaging pandas | |||
pip install -q visdom filelock tokenizers packaging pandas | |||
pip install -q mistune==2.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it's a short thought
Checked the following logs and ran a downgrade.
https://circleci.com/gh/pytorch/hub/2694
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was no problem with the history of merged without errors until 2022, and the mistune version at that time was 2.0.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A build error was displayed.
What do you think about modifying all libraries installed before a specific date to a version
- If the torch version goes down to the 1.x version, does it cause problems with interaction with other org pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cpprhtn !
bachnorm
->batchnorm
imagenet
->ImageNet
Because ImageNet is a proper noun, it retains the ImageNet word