Skip to content

Added eps to avoid nans in canberra error #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2021
Merged

Added eps to avoid nans in canberra error #1699

merged 2 commits into from
Feb 24, 2021

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Feb 24, 2021

Description:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5 vfdev-5 requested a review from sdesrozis February 24, 2021 22:31
@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Feb 24, 2021 •
edited
Loading

@sdesrozis can you review this please and merge if OK ?

sdesrozis
sdesrozis approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vfdev-5 looks good!

An alternative implementation could be using torch.nansum

@sdesrozis sdesrozis merged commit 087db74 into pytorch:master Feb 24, 2021
@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Feb 24, 2021 •
edited
Loading

I'm afraid nansum is something recent and not supported by pth 1.3.1. but yes we could use something like that...

@vfdev-5 vfdev-5 deleted the fix-canberra-error-nan branch February 24, 2021 23:05
@vfdev-5 vfdev-5 mentioned this pull request Feb 25, 2021
Closed
vfdev-5 added a commit that referenced this pull request Mar 1, 2021
@vfdev-5
Added eps to avoid nans in canberra error (#1699)
d09ed01
@vfdev-5 vfdev-5 mentioned this pull request Mar 1, 2021
Closed
@KickItLikeShika KickItLikeShika mentioned this pull request Mar 16, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sdesrozis sdesrozis sdesrozis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vfdev-5 @sdesrozis