Skip to content

Added full read permissions to saved file (1876) #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2021
Merged

Added full read permissions to saved file (1876) #1880

merged 3 commits into from
Mar 27, 2021

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Mar 26, 2021

Fixes #1876

Description:

  • Added full read rights to saved file when atomic=True

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5
Fixes pytorch#1876
a83c07e 
Added full read rights to saved file when atomic=True
@github-actions github-actions bot added the module: handlers Core Handlers module label Mar 26, 2021
@vfdev-5 vfdev-5 requested a review from sdesrozis March 26, 2021 12:35
@vfdev-5 vfdev-5 mentioned this pull request Mar 26, 2021
Closed
sdesrozis
sdesrozis approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good !

@sdesrozis
Copy link
Contributor

It misses mkl libs for tpu...

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Mar 26, 2021

I think it is the new pytorch release that fails our ci :)

@vfdev-5 vfdev-5 enabled auto-merge (squash) March 27, 2021 00:11
@vfdev-5 vfdev-5 merged commit 6bfb1f5 into pytorch:master Mar 27, 2021
@vfdev-5 vfdev-5 deleted the issue-1876-fix-file-mode branch March 28, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sdesrozis sdesrozis sdesrozis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
module: handlers Core Handlers module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkpoint handler save files with wrong permissions
2 participants
@vfdev-5 @sdesrozis