Skip to content

Commit

Permalink
ci: Use GITHUB_OUTPUT envvar instead of set-output command (#856)
Browse files Browse the repository at this point in the history
Summary:
`save-state` and `set-output` commands used in GitHub Actions are deprecated and [GitHub recommends using environment files](https://github.blog/changelog/2023-07-24-github-actions-update-on-save-state-and-set-output-commands/).

This PR updates the usage of `set-output` to `$GITHUB_OUTPUT`

Instructions for envvar usage from GitHub docs:

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter

Pull Request resolved: #856

Reviewed By: chaekit

Differential Revision: D52920751

Pulled By: aaronenyeshi

fbshipit-source-id: 619e2c2725cf14d80034de1470732a361f471f1e
  • Loading branch information
arunsathiya authored and facebook-github-bot committed Jan 20, 2024
1 parent 1703751 commit 3799f96
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/tb_plugin_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ jobs:
echo $GITHUB_BASE_REF
if [ $GITHUB_BASE_REF == "plugin/vnext" ]
then
echo "::set-output name=matrix::{\"python-version\":[3.8], \"cuda-version\":[\"cpu\"], \"pytorch-version\":[\"nightly\"]}"
echo "matrix={\"python-version\":[3.8], \"cuda-version\":[\"cpu\"], \"pytorch-version\":[\"nightly\"]}" >> "$GITHUB_OUTPUT"
else
echo "::set-output name=matrix::{\"python-version\":[3.8], \"cuda-version\":[\"cpu\"], \"pytorch-version\":[\"nightly\", \"2.0\", \"stable\"]}"
echo "matrix={\"python-version\":[3.8], \"cuda-version\":[\"cpu\"], \"pytorch-version\":[\"nightly\", \"2.0\", \"stable\"]}" >> "$GITHUB_OUTPUT"
fi
build:
Expand All @@ -40,14 +40,14 @@ jobs:
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
architecture: 'x64'
architecture: "x64"
- name: Test
env:
CUDA_VERSION: ${{ matrix.cuda-version }}
PYTORCH_VERSION: ${{ matrix.pytorch-version }}
TORCH_PROFILER_LOG_LEVEL: DEBUG
GRPC_VERBOSITY: DEBUG
GRPC_ENABLE_FORK_SUPPORT: 'False'
GRPC_ENABLE_FORK_SUPPORT: "False"
run: |
set -e
cd tb_plugin
Expand Down

0 comments on commit 3799f96

Please sign in to comment.