Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support collectives represented as user_annotation #765

Closed
wants to merge 1 commit into from
Closed

Support collectives represented as user_annotation #765

wants to merge 1 commit into from

Conversation

pbelevich
Copy link
Contributor

@pbelevich pbelevich commented Jun 7, 2023 •
edited
Loading

aaronenyeshi
aaronenyeshi approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@aaronenyeshi aaronenyeshi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Rebasing on latest main, and will try to get it landed.

@facebook-github-bot
Copy link
Contributor

@aaronenyeshi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@aaronenyeshi
Copy link
Member

Sorry, seems like there are CI failures, please double check these ones:

=========================== short test summary info ============================
FAILED test_tensorboard_end2end.py::TestEnd2End::test_tensorboard_end2end - AssertionError: b'{"m[12610 chars]WgradBOffsetsKernel(cask_cudnn::ComputeWgradBO[2287 chars]]]}}' != b'{"m[12610 chars]WgradSplitKOffsetsKernel(cask_cudnn::ComputeSp[2287 chars]]]}}'
FAILED test_tensorboard_end2end.py::TestEnd2End::test_tensorboard_with_path_prefix - AssertionError: b'{"m[12610 chars]WgradBOffsetsKernel(cask_cudnn::ComputeWgradBO[2287 chars]]]}}' != b'{"m[12610 chars]WgradSplitKOffsetsKernel(cask_cudnn::ComputeSp[2287 chars]]]}}'
FAILED test_tensorboard_end2end.py::TestEnd2End::test_tensorboard_with_symlinks - AssertionError: b'{"m[12610 chars]WgradBOffsetsKernel(cask_cudnn::ComputeWgradBO[2287 chars]]]}}' != b'{"m[12610 chars]WgradSplitKOffsetsKernel(cask_cudnn::ComputeSp[2287 chars]]]}}'
=================== 3 failed, 32 passed, 7 skipped in 44.18s ===================
Error: Process completed with exit code 1.

@aaronenyeshi
Copy link
Member

Looks like the CI failures is unrelated.

@facebook-github-bot
Copy link
Contributor

@aaronenyeshi merged this pull request in 6b280a5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronenyeshi aaronenyeshi aaronenyeshi approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No distributed view in tensorboard
3 participants
@pbelevich @facebook-github-bot @aaronenyeshi