Add API for Dynamic Activity Toggling [1/n] #972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: During PT2 there are many GPU/CPU events that are unneccessary to profile in between a given step. To remedy this, we can add an API that takes in a list of activities and an arg to toggle said activies or not. For this diff we are just adding the Kineto side to turn on/off the "CUDA" events which includes AMD/Roctracer. A follow up will be added for the generic profiler side. Subsequent diffs will be added for CPU toggling and e2e testing. Differential Revision: D60542040
|
This pull request was exported from Phabricator. Differential Revision: D60542040 |
|
This pull request has been merged in d975313. |
staugust
pushed a commit
to staugust/kineto
that referenced
this pull request
Aug 27, 2024
Summary: Pull Request resolved: pytorch#972 During PT2 there are many GPU/CPU events that are unneccessary to profile in between a given step. To remedy this, we can add an API that takes in a list of activities and an arg to toggle said activies or not. For this diff we are just adding the Kineto side to turn on/off the "CUDA" events which includes AMD/Roctracer. A follow up will be added for the generic profiler side. Subsequent diffs will be added for CPU toggling and e2e testing. Differential Revision: D60542040 fbshipit-source-id: 2608ec912812c9004cb87371bd8fca8145a95621
staugust
pushed a commit
to staugust/kineto
that referenced
this pull request
Aug 27, 2024
Summary: Pull Request resolved: pytorch#972 During PT2 there are many GPU/CPU events that are unneccessary to profile in between a given step. To remedy this, we can add an API that takes in a list of activities and an arg to toggle said activies or not. For this diff we are just adding the Kineto side to turn on/off the "CUDA" events which includes AMD/Roctracer. A follow up will be added for the generic profiler side. Subsequent diffs will be added for CPU toggling and e2e testing. Differential Revision: D60542040 fbshipit-source-id: 2608ec912812c9004cb87371bd8fca8145a95621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: During PT2 there are many GPU/CPU events that are unneccessary to profile in between a given step. To remedy this, we can add an API that takes in a list of activities and an arg to toggle said activies or not. For this diff we are just adding the Kineto side to turn on/off the "CUDA" events which includes AMD/Roctracer. A follow up will be added for the generic profiler side. Subsequent diffs will be added for CPU toggling and e2e testing.
Differential Revision: D60542040