Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conv3d grad sample test is failing currently: CircleCI
This is most likely due to a difference in
unfold3d
method between opacus and EW implementations.Opacus:
EW:
As dilation other than 1 is not supported under any conditions with EW, I've fixed then
is_ew_compatible
flag.PS: @ashkan-software do we have a github issue to update EW's
unfold3d
with the recent updates you made?