Fix layer type for cov #771
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76835339 |
Summary: compute_conv_grad_sample for conv layer uses layer type to reshape the activations. FSDPWrapper changes the layer type and therefore the layer type can not be directly determined by type(layer). Reviewed By: EnayatUllah Differential Revision: D76835339
facebook-github-bot
force-pushed
the
export-D76835339
branch
from
538f373 to
519bfda
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76835339 |
|
This pull request has been merged in 5f76567. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: compute_conv_grad_sample for conv layer uses layer type to reshape the activations. FSDPWrapper changes the layer type and therefore the layer type can not be directly determined by type(layer).
Differential Revision: D76835339