[c10d] C10d release to torch.distributed for PT1 #11405
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teng-li
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
pietern,
soumith and
zdevito
as code owners
teng-li
force-pushed
the
c10d_release
branch
from
1aea8d8 to
f8ce61d
Compare
teng-li
added
the
oncall: distributed
teng-li
force-pushed
the
c10d_release
branch
2 times, most recently
from
642ded8 to
83ceacc
Compare
|
@pytorchbot retest this please |
teng-li
force-pushed
the
c10d_release
branch
2 times, most recently
from
b54ba1a to
864bc53
Compare
|
@pytorchbot retest this please |
1 similar comment
|
@pytorchbot retest this please |
teng-li
force-pushed
the
c10d_release
branch
4 times, most recently
from
b060db9 to
f028081
Compare
teng-li
changed the title
|
@pietern This PR should be good to go. Please review/stamp |
There was a problem hiding this comment.
teng-li has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Please make sure to merge the gradient normalization change from here: #11109 |
teng-li
force-pushed
the
c10d_release
branch
from
f028081 to
60834e1
Compare
teng-li
force-pushed
the
c10d_release
branch
from
60834e1 to
c1f4720
Compare
There was a problem hiding this comment.
teng-li has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
pietern
approved these changes
Sep 11, 2018
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: The old `torch.distributed` will go to `torch.distributed.deprecated` The old DDP will go to `torch.nn.parallel.deprecated` Now `torch.nn.parallel.DDP` will use c10d DDP Now `torch.distributed` will use C10d frontend API Pull Request resolved: pytorch#11405 Reviewed By: pietern Differential Revision: D9733733 Pulled By: teng-li fbshipit-source-id: d6a3f3e73f8d3a7fcb1f4baef53c78063b8cbb08
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 11, 2018
…ibuted doc (#11450) Summary: This is the new documentation for c10d release, and it also deprecates the old torch.distributed document. This PR depends on #11405 and should only be landed after #11405 is landed Pull Request resolved: #11450 Differential Revision: D9765504 Pulled By: teng-li fbshipit-source-id: 48f38b27b8c270baf389f8e478ea226b9ecc63db
Closed
pietern
added a commit
to pietern/pytorch
that referenced
this pull request
Jun 25, 2019
It's been ~9 months since moving THD to the torch.distributed.deprecated namespace (see pytorch#11405) and we haven't seen issues related to it, so it's time to remove it. Closes pytorch#18967.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 25, 2019
Summary: It's been ~9 months since moving THD to the `torch.distributed.deprecated` namespace (see #11405) and we haven't seen issues related to it, so it's time to remove it. Closes #18967. Pull Request resolved: #22065 Reviewed By: mrshenli Differential Revision: D15983669 Pulled By: pietern fbshipit-source-id: 2a2f5866f9a63040bc7cef3956d5fd215aba7165
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 25, 2019
Summary: It's been ~9 months since moving THD to the `torch.distributed.deprecated` namespace (see pytorch/pytorch#11405) and we haven't seen issues related to it, so it's time to remove it. Closes pytorch/pytorch#18967. Pull Request resolved: pytorch/pytorch#22065 Reviewed By: mrshenli Differential Revision: D15983669 Pulled By: pietern fbshipit-source-id: 2a2f5866f9a63040bc7cef3956d5fd215aba7165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
torch.distributedwill go totorch.distributed.deprecatedThe old DDP will go to
torch.nn.parallel.deprecatedNow
torch.nn.parallel.DDPwill use c10d DDPNow
torch.distributedwill use C10d frontend API