-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Living branch / PR for FSDP development #103711
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP WIP WIP [dynamo x fsdp] Simplify stream logic handling WIP [dynamo x fsdp] Remove uncessary partials [dynamo x fsdp] Remove uncessary partials Lint [ghstack-poisoned]
This was referenced Jun 15, 2023
voznesenskym
added a commit
that referenced
this pull request
Jun 15, 2023
WIP WIP WIP [dynamo x fsdp] Simplify stream logic handling WIP [dynamo x fsdp] Remove uncessary partials [dynamo x fsdp] Remove uncessary partials Lint ghstack-source-id: 53fa805f61df8ab42b2f34c44c08d3b7d17f4544 Pull Request resolved: #103711
cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 [ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
Jun 29, 2023
WIP WIP WIP [dynamo x fsdp] Simplify stream logic handling WIP [dynamo x fsdp] Remove uncessary partials [dynamo x fsdp] Remove uncessary partials Lint ghstack-source-id: a0bc0311fb6f124591d9674e0f272b4e70be388a Pull Request resolved: #103711 WIP fixup fixup fixup fixup fixup Storage_offset Storage_offset Storage_offset Fix Fix Fixes Fixes Fixes Fixes
cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 [ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
Jun 29, 2023
WIP WIP WIP [dynamo x fsdp] Simplify stream logic handling WIP [dynamo x fsdp] Remove uncessary partials [dynamo x fsdp] Remove uncessary partials Lint ghstack-source-id: cc1756905a4914a308d459921679bfd22821000b Pull Request resolved: #103711 WIP fixup fixup fixup fixup fixup Storage_offset Storage_offset Storage_offset Fix Fix Fixes Fixes Fixes Fixes wip wip wip
cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 [ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
Jun 29, 2023
WIP WIP WIP [dynamo x fsdp] Simplify stream logic handling WIP [dynamo x fsdp] Remove uncessary partials [dynamo x fsdp] Remove uncessary partials Lint ghstack-source-id: 0be23f632a8207391cfb1d9a6ed1650ced832713 Pull Request resolved: #103711 WIP fixup fixup fixup fixup fixup Storage_offset Storage_offset Storage_offset Fix Fix Fixes Fixes Fixes Fixes wip wip wip wip
cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 [ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
Jun 30, 2023
WIP WIP WIP [dynamo x fsdp] Simplify stream logic handling WIP [dynamo x fsdp] Remove uncessary partials [dynamo x fsdp] Remove uncessary partials Lint ghstack-source-id: 8dce37296c8f6d385b965d94931030d65f0c7f62 Pull Request resolved: #103711 WIP fixup fixup fixup fixup fixup Storage_offset Storage_offset Storage_offset Fix Fix Fixes Fixes Fixes Fixes wip wip wip wip wip
cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 [ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
Jun 30, 2023
WIP WIP WIP [dynamo x fsdp] Simplify stream logic handling WIP [dynamo x fsdp] Remove uncessary partials [dynamo x fsdp] Remove uncessary partials Lint ghstack-source-id: ee900e764b1f4ef9c0b6346989c136d6f683b1e7 Pull Request resolved: #103711 WIP fixup fixup fixup fixup fixup Storage_offset Storage_offset Storage_offset Fix Fix Fixes Fixes Fixes Fixes wip wip wip wip wip wip wip wip
cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 [ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
Jun 30, 2023
WIP WIP WIP [dynamo x fsdp] Simplify stream logic handling WIP [dynamo x fsdp] Remove uncessary partials [dynamo x fsdp] Remove uncessary partials Lint ghstack-source-id: 9af6d961e82381c914baf8f8b4e77b7b964f4795 Pull Request resolved: #103711 WIP fixup fixup fixup fixup fixup Storage_offset Storage_offset Storage_offset Fix Fix Fixes Fixes Fixes Fixes wip wip wip wip wip wip wip wip wip
cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 [ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
Jul 6, 2023
WIP WIP WIP [dynamo x fsdp] Simplify stream logic handling WIP [dynamo x fsdp] Remove uncessary partials [dynamo x fsdp] Remove uncessary partials Lint ghstack-source-id: 45ec15c4a713f5fbd6e89fcf2bb038ef7b6669cf Pull Request resolved: #103711 WIP fixup fixup fixup fixup fixup Storage_offset Storage_offset Storage_offset Fix Fix Fixes Fixes Fixes Fixes wip wip wip wip wip wip wip wip wip
cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 [ghstack-poisoned]
This was referenced Jul 6, 2023
voznesenskym
added a commit
that referenced
this pull request
Jul 6, 2023
WIP WIP WIP [dynamo x fsdp] Simplify stream logic handling WIP [dynamo x fsdp] Remove uncessary partials [dynamo x fsdp] Remove uncessary partials Lint ghstack-source-id: b5e3719a1fa11a610b157400a9805465869208f2 Pull Request resolved: #103711 WIP fixup fixup fixup fixup fixup Storage_offset Storage_offset Storage_offset Fix Fix Fixes Fixes Fixes Fixes wip wip wip wip wip wip wip wip wip
cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 [ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
Jul 6, 2023
WIP WIP WIP [dynamo x fsdp] Simplify stream logic handling WIP [dynamo x fsdp] Remove uncessary partials [dynamo x fsdp] Remove uncessary partials Lint ghstack-source-id: 206c75826d65a6c1a0758c5ceca4fec6878b1a13 Pull Request resolved: #103711 WIP fixup fixup fixup fixup fixup Storage_offset Storage_offset Storage_offset Fix Fix Fixes Fixes Fixes Fixes wip wip wip wip wip wip wip wip wip Undo
voznesenskym
added a commit
that referenced
this pull request
Jul 19, 2023
WIP WIP WIP [dynamo x fsdp] Simplify stream logic handling WIP [dynamo x fsdp] Remove uncessary partials [dynamo x fsdp] Remove uncessary partials Lint ghstack-source-id: 206c75826d65a6c1a0758c5ceca4fec6878b1a13 Pull Request resolved: #103711 WIP fixup fixup fixup fixup fixup Storage_offset Storage_offset Storage_offset Fix Fix Fixes Fixes Fixes Fixes wip wip wip wip wip wip wip wip wip Undo
voznesenskym
added a commit
that referenced
this pull request
Jul 21, 2023
WIP WIP WIP [dynamo x fsdp] Simplify stream logic handling WIP [dynamo x fsdp] Remove uncessary partials [dynamo x fsdp] Remove uncessary partials Lint ghstack-source-id: 206c75826d65a6c1a0758c5ceca4fec6878b1a13 Pull Request resolved: #103711 WIP fixup fixup fixup fixup fixup Storage_offset Storage_offset Storage_offset Fix Fix Fixes Fixes Fixes Fixes wip wip wip wip wip wip wip wip wip Undo
voznesenskym
added a commit
that referenced
this pull request
Aug 7, 2023
WIP WIP WIP [dynamo x fsdp] Simplify stream logic handling WIP [dynamo x fsdp] Remove uncessary partials [dynamo x fsdp] Remove uncessary partials Lint ghstack-source-id: 206c75826d65a6c1a0758c5ceca4fec6878b1a13 Pull Request resolved: #103711 WIP fixup fixup fixup fixup fixup Storage_offset Storage_offset Storage_offset Fix Fix Fixes Fixes Fixes Fixes wip wip wip wip wip wip wip wip wip Undo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
ModuleWrapPolicy
#104427ignored_states
+ auto wrap (for now) #104418_get_fully_sharded_module_to_states
#104409fully_shard
auto wrap #104408_auto_wrap
forfully_shard
#104407ModuleWrapPolicy
to new path #104346fully_shard
#104363cc @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @ipiszy @chenyang78