[FSDP][4/N] Remove _get_fully_sharded_module_to_states
#104409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104409
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2660f4c: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
This was referenced Jun 29, 2023
awgu
added a commit
that referenced
this pull request
Jun 29, 2023
ghstack-source-id: d543bca70c50162e2e0566e973aceee805cbed60 Pull Request resolved: #104409
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jun 29, 2023
ghstack-source-id: d543bca70c50162e2e0566e973aceee805cbed60 Pull Request resolved: pytorch#104409
`_get_fully_sharded_module_to_states()` was used to emulate auto wrapping without actually calling `fully_shard`. Since we committed to unifying (see previous PR), we can remove this function and its helpers/tests. [ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Jun 29, 2023
ghstack-source-id: 2cba28a2d666236440a33cf9902c8242dd395619 Pull Request resolved: #104409
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jun 29, 2023
ghstack-source-id: 2cba28a2d666236440a33cf9902c8242dd395619 Pull Request resolved: pytorch#104409
`_get_fully_sharded_module_to_states()` was used to emulate auto wrapping without actually calling `fully_shard`. Since we committed to unifying (see previous PR), we can remove this function and its helpers/tests. [ghstack-poisoned]
`_get_fully_sharded_module_to_states()` was used to emulate auto wrapping without actually calling `fully_shard`. Since we committed to unifying (see previous PR), we can remove this function and its helpers/tests. [ghstack-poisoned]
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jun 29, 2023
ghstack-source-id: c004d4449be8138b816d316dfb2d609e344c9dde Pull Request resolved: pytorch#104409
`_get_fully_sharded_module_to_states()` was used to emulate auto wrapping without actually calling `fully_shard`. Since we committed to unifying (see previous PR), we can remove this function and its helpers/tests. [ghstack-poisoned]
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jun 30, 2023
ghstack-source-id: 8396d44dcfe1e3d5c61f934e9802ce44e7f96a3f Pull Request resolved: pytorch#104409
`_get_fully_sharded_module_to_states()` was used to emulate auto wrapping without actually calling `fully_shard`. Since we committed to unifying (see previous PR), we can remove this function and its helpers/tests. [ghstack-poisoned]
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jun 30, 2023
ghstack-source-id: b81b73bc70ea7e1145db055a81bca7dbabcd5cd8 Pull Request resolved: pytorch#104409
`_get_fully_sharded_module_to_states()` was used to emulate auto wrapping without actually calling `fully_shard`. Since we committed to unifying (see previous PR), we can remove this function and its helpers/tests. [ghstack-poisoned]
`_get_fully_sharded_module_to_states()` was used to emulate auto wrapping without actually calling `fully_shard`. Since we committed to unifying (see previous PR), we can remove this function and its helpers/tests. [ghstack-poisoned]
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jun 30, 2023
ghstack-source-id: 5cccf8de845be6f8c6559c988d9d61b02fc7c287 Pull Request resolved: pytorch#104409
`_get_fully_sharded_module_to_states()` was used to emulate auto wrapping without actually calling `fully_shard`. Since we committed to unifying (see previous PR), we can remove this function and its helpers/tests. [ghstack-poisoned]
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jul 5, 2023
ghstack-source-id: 76d394ad6c81c8b1ae4456b74875880b9916edf8 Pull Request resolved: pytorch#104409
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jul 5, 2023
ghstack-source-id: 76d394ad6c81c8b1ae4456b74875880b9916edf8 Pull Request resolved: pytorch#104409
`_get_fully_sharded_module_to_states()` was used to emulate auto wrapping without actually calling `fully_shard`. Since we committed to unifying (see previous PR), we can remove this function and its helpers/tests. [ghstack-poisoned]
awgu
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
kwen2501,
wanchaol,
fegin,
fduwjj,
kiukchung and
d4l3k
as code owners
`_get_fully_sharded_module_to_states()` was used to emulate auto wrapping without actually calling `fully_shard`. Since we committed to unifying (see previous PR), we can remove this function and its helpers/tests. [ghstack-poisoned]
This was referenced Jul 6, 2023
`_get_fully_sharded_module_to_states()` was used to emulate auto wrapping without actually calling `fully_shard`. Since we committed to unifying (see previous PR), we can remove this function and its helpers/tests. [ghstack-poisoned]
rohan-varma
approved these changes
Jul 6, 2023
fegin
approved these changes
Jul 7, 2023
`_get_fully_sharded_module_to_states()` was used to emulate auto wrapping without actually calling `fully_shard`. Since we committed to unifying (see previous PR), we can remove this function and its helpers/tests. [ghstack-poisoned]
`_get_fully_sharded_module_to_states()` was used to emulate auto wrapping without actually calling `fully_shard`. Since we committed to unifying (see previous PR), we can remove this function and its helpers/tests. [ghstack-poisoned]
`_get_fully_sharded_module_to_states()` was used to emulate auto wrapping without actually calling `fully_shard`. Since we committed to unifying (see previous PR), we can remove this function and its helpers/tests. [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
ModuleWrapPolicy#104427ignored_states+ auto wrap (for now) #104418_get_fully_sharded_module_to_states#104409fully_shardauto wrap #104408_auto_wrapforfully_shard#104407ModuleWrapPolicyto new path #104346_get_fully_sharded_module_to_states()was used to emulate auto wrapping without actually callingfully_shard. Since we committed to unifying (see previous PR), we can remove this function and its helpers/tests.