[FSDP] Annotate modules for fully_shard
#104363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104363
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ad2a45a: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
awgu
added a commit
that referenced
this pull request
Jun 28, 2023
ghstack-source-id: 76cfa78206a5d3ad44629eb1a1d5a84b834aea8b Pull Request resolved: #104363
This was referenced Jun 29, 2023
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jun 29, 2023
ghstack-source-id: 76cfa78206a5d3ad44629eb1a1d5a84b834aea8b Pull Request resolved: pytorch#104363
This annotates modules managed by `fully_shard` for TorchDynamo to treat them specially. [ghstack-poisoned]
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jun 29, 2023
ghstack-source-id: b62d622a3c0745bc3149202a81ac730a7aefe995 Pull Request resolved: pytorch#104363
This annotates modules managed by `fully_shard` for TorchDynamo to treat them specially. [ghstack-poisoned]
awgu
added
release notes: distributed (fsdp)
awgu
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
kwen2501,
wanchaol,
fegin,
fduwjj,
yhcharles,
kiukchung and
d4l3k
as code owners
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jun 29, 2023
ghstack-source-id: be9cf1181242ab75d34769e67e89a04b41334271 Pull Request resolved: pytorch#104363
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jul 5, 2023
ghstack-source-id: be9cf1181242ab75d34769e67e89a04b41334271 Pull Request resolved: pytorch#104363
This annotates modules managed by `fully_shard` for TorchDynamo to treat them specially. [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
ModuleWrapPolicy#104427ignored_states+ auto wrap (for now) #104418_get_fully_sharded_module_to_states#104409fully_shardauto wrap #104408_auto_wrapforfully_shard#104407ModuleWrapPolicyto new path #104346fully_shard#104363This annotates modules managed by
fully_shardfor TorchDynamo to treat them specially.