[FSDP][2/N][Easy] Prepare _auto_wrap for fully_shard
#104407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104407
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4ad6bfe: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 28, 2023
This mainly just changes the `_auto_wrap()` function signature and generalizes the `_check_nested_wrapping()` to both wrapper and composable paths (though the composable path will not hit in this PR). [ghstack-poisoned]
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jun 29, 2023
ghstack-source-id: 089b3c0c57b96992a69ab2963a9329379f6a3ae9 Pull Request resolved: pytorch#104407
This mainly just changes the `_auto_wrap()` function signature and generalizes the `_check_nested_wrapping()` to both wrapper and composable paths (though the composable path will not hit in this PR). [ghstack-poisoned]
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jun 29, 2023
ghstack-source-id: d5085f211f31ab81ed7351a037f3c59b7caff515 Pull Request resolved: pytorch#104407
This mainly just changes the `_auto_wrap()` function signature and generalizes the `_check_nested_wrapping()` to both wrapper and composable paths (though the composable path will not hit in this PR). [ghstack-poisoned]
This was referenced Jun 29, 2023
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jun 29, 2023
ghstack-source-id: d5085f211f31ab81ed7351a037f3c59b7caff515 Pull Request resolved: pytorch#104407
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jun 30, 2023
ghstack-source-id: d5085f211f31ab81ed7351a037f3c59b7caff515 Pull Request resolved: pytorch#104407
This mainly just changes the `_auto_wrap()` function signature and generalizes the `_check_nested_wrapping()` to both wrapper and composable paths (though the composable path will not hit in this PR). [ghstack-poisoned]
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jun 30, 2023
ghstack-source-id: 5ddac4a855b68c385b0ec636a3e14732b43f820f Pull Request resolved: pytorch#104407
This mainly just changes the `_auto_wrap()` function signature and generalizes the `_check_nested_wrapping()` to both wrapper and composable paths (though the composable path will not hit in this PR). [ghstack-poisoned]
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jul 5, 2023
ghstack-source-id: 20887bbf21c40d47d8ceee6f8a754e47bd5169f7 Pull Request resolved: pytorch#104407
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jul 5, 2023
ghstack-source-id: 20887bbf21c40d47d8ceee6f8a754e47bd5169f7 Pull Request resolved: pytorch#104407
This mainly just changes the `_auto_wrap()` function signature and generalizes the `_check_nested_wrapping()` to both wrapper and composable paths (though the composable path will not hit in this PR). [ghstack-poisoned]
awgu
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
kwen2501 and
wanchaol
as code owners
This mainly just changes the `_auto_wrap()` function signature and generalizes the `_check_nested_wrapping()` to both wrapper and composable paths (though the composable path will not hit in this PR). [ghstack-poisoned]
This was referenced Jul 6, 2023
This mainly just changes the `_auto_wrap()` function signature and generalizes the `_check_nested_wrapping()` to both wrapper and composable paths (though the composable path will not hit in this PR). [ghstack-poisoned]
rohan-varma
approved these changes
Jul 6, 2023
fegin
approved these changes
Jul 7, 2023
This mainly just changes the `_auto_wrap()` function signature and generalizes the `_check_nested_wrapping()` to both wrapper and composable paths (though the composable path will not hit in this PR). [ghstack-poisoned]
This mainly just changes the `_auto_wrap()` function signature and generalizes the `_check_nested_wrapping()` to both wrapper and composable paths (though the composable path will not hit in this PR). [ghstack-poisoned]
This mainly just changes the `_auto_wrap()` function signature and generalizes the `_check_nested_wrapping()` to both wrapper and composable paths (though the composable path will not hit in this PR). [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
ModuleWrapPolicy#104427ignored_states+ auto wrap (for now) #104418_get_fully_sharded_module_to_states#104409fully_shardauto wrap #104408_auto_wrapforfully_shard#104407ModuleWrapPolicyto new path #104346This mainly just changes the
_auto_wrap()function signature and generalizes the_check_nested_wrapping()to both wrapper and composable paths (though the composable path will not hit in this PR).