[quant] Remove reference representation rewrite for adaptive_avg_pool2d #108924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108924
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0f6a1e2 with merge base 90068ab ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 8, 2023
kimishpatel
approved these changes
Sep 11, 2023
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 14, 2023
…108925) Summary: this is no longer needed since we have the quantizer api now Test Plan: . Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: #108925 Approved by: https://github.com/andrewor14 ghstack dependencies: #108924
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 15, 2023
…109158) Summary: att Test Plan: python test/test_quantization.py TestQuantizePT2E.test_save_load Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: #109158 Approved by: https://github.com/andrewor14 ghstack dependencies: #108924, #108925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and
this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now.
we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well
Test Plan:
python test/test_quantization.py TestQuantizePT2ERepresentation
Reviewers:
Subscribers:
Tasks:
Tags: