-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[quant] Remove reference representation rewrite for adaptive_avg_pool2d #108924
Conversation
Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108924
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0f6a1e2 with merge base 90068ab (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ve_avg_pool2d" Summary: integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now. we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well Test Plan: python test/test_quantization.py TestQuantizePT2ERepresentation Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…108925) Summary: this is no longer needed since we have the quantizer api now Test Plan: . Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: #108925 Approved by: https://github.com/andrewor14 ghstack dependencies: #108924
…109158) Summary: att Test Plan: python test/test_quantization.py TestQuantizePT2E.test_save_load Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: #109158 Approved by: https://github.com/andrewor14 ghstack dependencies: #108924, #108925
Stack from ghstack (oldest at bottom):
Summary:
integer adaptive_avg_pool2d is not well defined due to different possible ways of rounding fp32 value to integer value, and
this op isn't too critical for numerics (since it appears not too often), so we'll skip this for now.
we might need to revert the changes that adds integer impl for adaptive_avg_pool op as well
Test Plan:
python test/test_quantization.py TestQuantizePT2ERepresentation
Reviewers:
Subscribers:
Tasks:
Tags: