Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop warnings on AT_DECLARE_TENSOR_TYPE(.); #12348

Closed
wants to merge 1 commit into from
Closed

Conversation

ssnl
Copy link
Collaborator

@ssnl ssnl commented Oct 4, 2018

e.g.,

│../aten/src/ATen/core/TensorTypeIdRegistration.h:101:43: warning: extra ‘;’ [-Wpedantic]
│ AT_DECLARE_TENSOR_TYPE(SparseCUDATensorId);

Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SsnL is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ssnl ssnl deleted the warnn branch October 5, 2018 06:43
zdevito pushed a commit to zdevito/ATen that referenced this pull request Oct 5, 2018
Summary:
e.g.,
```
│../aten/src/ATen/core/TensorTypeIdRegistration.h:101:43: warning: extra ‘;’ [-Wpedantic]
│ AT_DECLARE_TENSOR_TYPE(SparseCUDATensorId);
```
Pull Request resolved: pytorch/pytorch#12348

Differential Revision: D10210072

Pulled By: SsnL

fbshipit-source-id: 90eacc97ef490148c0ac1357cf28f1326a791dfa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants