New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opcheck should be usable without optional dependencies #127292

Closed

zou3519 wants to merge 5 commits into gh/zou3519/994/base from gh/zou3519/994/head

+74 −49

Commits on May 28, 2024

opcheck should be usable without optional dependencies

This PR excises opcheck's dependency on
torch.testing._internal.common_utils, (which comes with dependencies on
expecttest and hypothesis). We do this by moving what we need to
torch.testing._utils and adding a test for it.

Fixes #126870, #126871

Test Plan:
- new tests

[ghstack-poisoned]

zou3519 committed May 28, 2024

Update on "opcheck should be usable without optional dependencies"

This PR excises opcheck's dependency on
torch.testing._internal.common_utils, (which comes with dependencies on
expecttest and hypothesis). We do this by moving what we need to
torch.testing._utils and adding a test for it.

Fixes #126870, #126871

Test Plan:
- new tests

[ghstack-poisoned]

zou3519 committed May 28, 2024

Update on "opcheck should be usable without optional dependencies"

This PR excises opcheck's dependency on
torch.testing._internal.common_utils, (which comes with dependencies on
expecttest and hypothesis). We do this by moving what we need to
torch.testing._utils and adding a test for it.

Fixes #126870, #126871

Test Plan:
- new tests

[ghstack-poisoned]

zou3519 committed May 28, 2024

Update on "opcheck should be usable without optional dependencies"

This PR excises opcheck's dependency on
torch.testing._internal.common_utils, (which comes with dependencies on
expecttest and hypothesis). We do this by moving what we need to
torch.testing._utils and adding a test for it.

Fixes #126870, #126871

Test Plan:
- new tests

[ghstack-poisoned]

zou3519 committed May 28, 2024

Commits on May 29, 2024

Update on "opcheck should be usable without optional dependencies"

This PR excises opcheck's dependency on
torch.testing._internal.common_utils, (which comes with dependencies on
expecttest and hypothesis). We do this by moving what we need to
torch.testing._utils and adding a test for it.

Fixes #126870, #126871

Test Plan:
- new tests

[ghstack-poisoned]

zou3519 committed May 29, 2024