[quant][graphmode][fx] Support non_traceable_module/module_class #46298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Allow user to specify a list of qualified names for non traceable submodule or type of the non traceable submodule See quantize_fx.py for api Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit a881f90 (more details on the Dr. CI page): Commit a881f90 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 times. |
…_class" Summary: Allow user to specify a list of qualified names for non traceable submodule or type of the non traceable submodule See quantize_fx.py for api Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24294210](https://our.internmc.facebook.com/intern/diff/D24294210) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Oct 14, 2020
Summary: Allow user to specify a list of qualified names for non traceable submodule or type of the non traceable submodule See quantize_fx.py for api Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 8b99f426c3bd78629d8eec7839c7361802e36aff Pull Request resolved: #46298
💊 CI failures summary and remediationsAs of commit 3b06d99 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 5 ongoing upstream failures:These were probably caused by upstream breakages that are not fixed yet:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 24 times. |
…_class" Summary: Allow user to specify a list of qualified names for non traceable submodule or type of the non traceable submodule See quantize_fx.py for api Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24294210](https://our.internmc.facebook.com/intern/diff/D24294210) [ghstack-poisoned]
This was referenced Oct 14, 2020
Closed
…_class" Summary: Allow user to specify a list of qualified names for non traceable submodule or type of the non traceable submodule See quantize_fx.py for api Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24294210](https://our.internmc.facebook.com/intern/diff/D24294210) [ghstack-poisoned]
vkuzo
approved these changes
Oct 15, 2020
Comment on lines
+798
to
+805
| prepare_custom_config_dict = { | ||
| "non_traceable_module_name": [ | ||
| "m1" | ||
| ], | ||
| "non_traceable_module_class": [ | ||
| NonTraceable2 | ||
| ] | ||
| } |
…_class" Summary: Allow user to specify a list of qualified names for non traceable submodule or type of the non traceable submodule See quantize_fx.py for api Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24294210](https://our.internmc.facebook.com/intern/diff/D24294210) [ghstack-poisoned]
|
This pull request has been merged in a06b95b. |
1 similar comment
|
This pull request has been merged in a06b95b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Allow user to specify a list of qualified names for non traceable submodule
or type of the non traceable submodule
See quantize_fx.py for api
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D24294210