Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[quant][graphmode][fx] Add support for additional_{fusion/quant}_pattern #46346

Closed
wants to merge 12 commits into from
Closed

[quant][graphmode][fx] Add support for additional_{fusion/quant}_pattern #46346

wants to merge 12 commits into from

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Oct 14, 2020 •
edited

Stack from ghstack:

Summary:
Allow user to provide additional fusion/quant patterns for fx graph mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D24317437

@jerryzh168
[quant][graphmode][fx] Add support for additional_{fusion/quant}_pattern
0f78cca 
Summary:
Allow user to provide additional fusion/quant patterns for fx graph mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
This was referenced Oct 14, 2020
Closed
Closed
Closed
Closed
Closed
jerryzh168 added a commit that referenced this pull request Oct 14, 2020
@jerryzh168
[quant][graphmode][fx] Add support for additional_{fusion/quant}_pattern
fde5c0c 
Summary:
Allow user to provide additional fusion/quant patterns for fx graph mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: fd387cbfeccff6b5ba70a812ba0d383a9d7128a8
Pull Request resolved: #46346
@dr-ci
Copy link

dr-ci bot commented Oct 14, 2020 •
edited

💊 CI failures summary and remediations

As of commit 4d35c6f (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 79 times.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 14, 2020 •
edited

💊 CI failures summary and remediations

As of commit 0f78cca (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)---

1 failure not recognized by patterns:

Job Step Action
CircleCI docker-pytorch-linux-xenial-py3-clang5-android-ndk-r19c Check if image should be built 🔁 rerun

Extra GitHub checks: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

@jerryzh168
Update on "[quant][graphmode][fx] Add support for additional_{fusion/…
2c1f44f 
…quant}_pattern"

Summary:
Allow user to provide additional fusion/quant patterns for fx graph mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24317437](https://our.internmc.facebook.com/intern/diff/D24317437)

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request Oct 14, 2020
Closed
vkuzo
vkuzo approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@vkuzo vkuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, should we add a test?

torch/quantization/quantize_fx.py Outdated Show resolved Hide resolved
@jerryzh168
Update on "[quant][graphmode][fx] Add support for additional_{fusion/…
5e3100c 
…quant}_pattern"

Summary:
Allow user to provide additional fusion/quant patterns for fx graph mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24317437](https://our.internmc.facebook.com/intern/diff/D24317437)

[ghstack-poisoned]
@jerryzh168
Copy link
Contributor Author

lg, should we add a test?

was thinking of adding them when we have the first real use case so that we don't need to make things up.

@jerryzh168
Update on "[quant][graphmode][fx] Add support for additional_{fusion/…
34ca67a 
…quant}_pattern"

Summary:
Allow user to provide additional fusion/quant patterns for fx graph mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24317437](https://our.internmc.facebook.com/intern/diff/D24317437)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode][fx] Add support for additional_{fusion/…
78c1fba 
…quant}_pattern"

Summary:
Allow user to provide additional fusion/quant patterns for fx graph mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24317437](https://our.internmc.facebook.com/intern/diff/D24317437)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode][fx] Add support for additional_{fusion/…
eb95e3d 
…quant}_pattern"

Summary:
Allow user to provide additional fusion/quant patterns for fx graph mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24317437](https://our.internmc.facebook.com/intern/diff/D24317437)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode][fx] Add support for additional_{fusion/…
596e085 
…quant}_pattern"

Summary:
Allow user to provide additional fusion/quant patterns for fx graph mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24317437](https://our.internmc.facebook.com/intern/diff/D24317437)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode][fx] Add support for additional_{fusion/…
3d6442b 
…quant}_pattern"

Summary:
Allow user to provide additional fusion/quant patterns for fx graph mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24317437](https://our.internmc.facebook.com/intern/diff/D24317437)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode][fx] Add support for additional_{fusion/…
4a78030 
…quant}_pattern"

Summary:
Allow user to provide additional fusion/quant patterns for fx graph mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24317437](https://our.internmc.facebook.com/intern/diff/D24317437)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode][fx] Add support for additional_{fusion/…
d62ccc8 
…quant}_pattern"

Summary:
Allow user to provide additional fusion/quant patterns for fx graph mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24317437](https://our.internmc.facebook.com/intern/diff/D24317437)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode][fx] Add support for additional_{fusion/…
3824fc7 
…quant}_pattern"

Summary:
Allow user to provide additional fusion/quant patterns for fx graph mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24317437](https://our.internmc.facebook.com/intern/diff/D24317437)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode][fx] Add support for additional_{fusion/…
4d35c6f 
…quant}_pattern"

Summary:
Allow user to provide additional fusion/quant patterns for fx graph mode

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D24317437](https://our.internmc.facebook.com/intern/diff/D24317437)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 343260a.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/470/head branch October 27, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkuzo vkuzo vkuzo approved these changes

Assignees
No one assigned
Labels
Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jerryzh168 @facebook-github-bot @vkuzo