[quant][graphmode][fx] Add additional_object_mapping argument to convert #46338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Should we merge quantized module and quantized operator configurations? Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Oct 14, 2020
💊 CI failures summary and remediationsAs of commit fa30163 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 3 times. |
jerryzh168
added a commit
that referenced
this pull request
Oct 14, 2020
Summary: Should we merge quantized module and quantized operator configurations? Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 10943071019e521738223d287feb91b8a438ea15 Pull Request resolved: #46338
💊 CI failures summary and remediationsAs of commit a702a6f (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 45 times. |
This was referenced Oct 14, 2020
…ent to convert" Summary: Should we merge quantized module and quantized operator configurations? Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24317435](https://our.internmc.facebook.com/intern/diff/D24317435) [ghstack-poisoned]
vkuzo
reviewed
Oct 15, 2020
Comment on lines
+259
to
+266
| "static": { | ||
| FloatModule: QuantizedModule, | ||
| float_op: quantized_op | ||
| }, | ||
| "dynamic": { | ||
| FloatModule: DynamicallyQuantizedModule, | ||
| float_op: dynamically_quantized_op | ||
| }, |
There was a problem hiding this comment.
how would custom mappings for QAT, and/or for models which have some parts quantized dynamically and statically fit?
There was a problem hiding this comment.
you mean additional qat module mappings? it's added in the next PR. it's kind of independent from these, it happens before we insert observer, e.g. we swap nn.Conv2d to nn.qat.Conv2d
"static" and "dynamic" here are used during convert, e.g. nn.qat.Conv2d to nn.quantized.Conv2d
vkuzo
approved these changes
Oct 15, 2020
…ent to convert" Summary: Should we merge quantized module and quantized operator configurations? Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24317435](https://our.internmc.facebook.com/intern/diff/D24317435) [ghstack-poisoned]
…ent to convert" Summary: Should we merge quantized module and quantized operator configurations? Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24317435](https://our.internmc.facebook.com/intern/diff/D24317435) [ghstack-poisoned]
…ent to convert" Summary: Should we merge quantized module and quantized operator configurations? Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24317435](https://our.internmc.facebook.com/intern/diff/D24317435) [ghstack-poisoned]
…ent to convert" Summary: Should we merge quantized module and quantized operator configurations? Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24317435](https://our.internmc.facebook.com/intern/diff/D24317435) [ghstack-poisoned]
…ent to convert" Summary: Should we merge quantized module and quantized operator configurations? Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24317435](https://our.internmc.facebook.com/intern/diff/D24317435) [ghstack-poisoned]
|
This pull request has been merged in 746febd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Should we merge quantized module and quantized operator configurations?
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D24317435