[quant][refactor] Remove register api and rename get_*_mapping to get_default_*_mapping #46337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_default_*_mapping Summary: We plan to pass around the mappings instead of using global registration api to keep the mappings local to the transformations user is performing Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit ce57dad (more details on the Dr. CI page):
1 failure not recognized by patterns:
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 3 times. |
This was referenced Oct 14, 2020
💊 CI failures summary and remediationsAs of commit a59415d (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 5 ongoing upstream failures:These were probably caused by upstream breakages that are not fixed yet:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 24 times. |
This was referenced Oct 14, 2020
…ping to get_default_*_mapping" Summary: We plan to pass around the mappings instead of using global registration api to keep the mappings local to the transformations user is performing Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24317436](https://our.internmc.facebook.com/intern/diff/D24317436) [ghstack-poisoned]
vkuzo
approved these changes
Oct 15, 2020
…ping to get_default_*_mapping" Summary: We plan to pass around the mappings instead of using global registration api to keep the mappings local to the transformations user is performing Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24317436](https://our.internmc.facebook.com/intern/diff/D24317436) [ghstack-poisoned]
|
This pull request has been merged in f9446cb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
We plan to pass around the mappings instead of using global registration api to keep
the mappings local to the transformations user is performing
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D24317436