Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fx quant: clean up functions in _generate_qconfig_map #48772

Closed
wants to merge 1 commit into from

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Dec 3, 2020

Stack from ghstack:

Summary:

Makes util functions in _generate_qconfig_map have no side
effects, all dependencies are now in arguments.

Test Plan:

python test/test_quantization.py TestQuantizeFx

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D25295837

Summary:

Makes util functions in `_generate_qconfig_map` have no side
effects, all dependencies are now in arguments.

Test Plan:

```
python test/test_quantization.py TestQuantizeFx
```

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@dr-ci
Copy link

dr-ci bot commented Dec 3, 2020

💊 CI failures summary and remediations

As of commit dab13b4 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test1 (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

[ FAILED ] MathKernelTest.NativeLayerNorm
Expected: true 
[  FAILED  ] MathKernelTest.NativeLayerNorm (6 ms) 
[ RUN      ] MathKernelTest.Addr 
[       OK ] MathKernelTest.Addr (1 ms) 
[----------] 3 tests from MathKernelTest (15 ms total) 
 
[----------] Global test environment tear-down 
[==========] 3 tests from 1 test case ran. (15 ms total) 
[  PASSED  ] 2 tests. 
[  FAILED  ] 1 test, listed below: 
[  FAILED  ] MathKernelTest.NativeLayerNorm 
 
 1 FAILED TEST 
"math_kernel_test" failed with exit code 1 
+ cleanup
+ retcode=1
+ set +x

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 536352e.

@facebook-github-bot facebook-github-bot deleted the gh/vkuzo/174/head branch December 7, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants