fx quant: more typehints, part 2 #48792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds some more typehints throughout quantization/fx/quantize.py, to help with readability. Test Plan: ``` mypy torch/quantization/fx/quantize.py ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Dec 3, 2020
vkuzo
added a commit
that referenced
this pull request
Dec 3, 2020
Summary: Adds some more typehints throughout quantization/fx/quantize.py, to help with readability. Test Plan: ``` mypy torch/quantization/fx/quantize.py ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 9971ce617179d1b7a7b3e968865796d0e626bf06 Pull Request resolved: #48792
jerryzh168
approved these changes
Dec 3, 2020
Codecov Report
@@ Coverage Diff @@
## gh/vkuzo/177/base #48792 +/- ##
=====================================================
- Coverage 80.73% 80.73% -0.01%
=====================================================
Files 1863 1863
Lines 200895 200897 +2
=====================================================
- Hits 162187 162185 -2
- Misses 38708 38712 +4 |
|
This pull request has been merged in 54da2da. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Adds some more typehints throughout quantization/fx/quantize.py,
to help with readability.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D25306683