fx quant: more typehints, part 3 #48794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds typehints to function I/O in `torch/quantization/quantize_fx.py`, for readability. Test Plan: ``` mypy torch/quantization/ ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Dec 3, 2020
vkuzo
added a commit
that referenced
this pull request
Dec 3, 2020
Summary: Adds typehints to function I/O in `torch/quantization/quantize_fx.py`, for readability. Test Plan: ``` mypy torch/quantization/ ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: daad7f141e85bc2c8d9ed415f19094c3a444fa7a Pull Request resolved: #48794
jerryzh168
approved these changes
Dec 3, 2020
Codecov Report
@@ Coverage Diff @@
## gh/vkuzo/178/base #48794 +/- ##
==================================================
Coverage 80.73% 80.73%
==================================================
Files 1863 1863
Lines 200897 200898 +1
==================================================
+ Hits 162185 162186 +1
Misses 38712 38712 |
|
This pull request has been merged in f5d9424. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Adds typehints to function I/O in
torch/quantization/quantize_fx.py,for readability.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D25307084