fx quant: add more typehints #48774
Closed
fx quant: add more typehints #48774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds some more typehints throughout `quantization/fx/quantize.py`. More are needed, ran out of time for now, we can continue in future PRs. Test Plan: ``` mypy torch/quantization/fx/quantize.py ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Dec 3, 2020
vkuzo
added a commit
that referenced
this pull request
Dec 3, 2020
Summary: Adds some more typehints throughout `quantization/fx/quantize.py`. More are needed, ran out of time for now, we can continue in future PRs. Test Plan: ``` mypy torch/quantization/fx/quantize.py ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 6953ed5e502fe72e302b6ea07eba6977e3e50cfa Pull Request resolved: #48774
Codecov Report
@@ Coverage Diff @@
## gh/vkuzo/176/base #48774 +/- ##
=====================================================
+ Coverage 80.59% 80.73% +0.13%
=====================================================
Files 1863 1863
Lines 200876 200895 +19
=====================================================
+ Hits 161905 162187 +282
+ Misses 38971 38708 -263 |
This was referenced Dec 3, 2020
jerryzh168
approved these changes
Dec 3, 2020
|
This pull request has been merged in f5bcf45. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Adds some more typehints throughout
quantization/fx/quantize.py.More are needed, ran out of time for now, we can continue in
future PRs.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D25295836