[PyTorch] Avoid extra Tensor refcounting in _cat_out_cpu #49364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a local `Tensor` when we only needed a `const Tensor&`. Differential Revision: [D25544731](https://our.internmc.facebook.com/intern/diff/D25544731/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25544731/)! [ghstack-poisoned]
This was referenced Dec 14, 2020
swolchok
added a commit
that referenced
this pull request
Dec 14, 2020
We had a local `Tensor` when we only needed a `const Tensor&`. Differential Revision: [D25544731](https://our.internmc.facebook.com/intern/diff/D25544731/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25544731/)! ghstack-source-id: 118559137 Pull Request resolved: #49364
This was referenced Dec 14, 2020
💊 CI failures summary and remediationsAs of commit e514f62 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 5 times. |
We had a local `Tensor` when we only needed a `const Tensor&`. Differential Revision: [D25544731](https://our.internmc.facebook.com/intern/diff/D25544731/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25544731/)! [ghstack-poisoned]
|
This pull request has been merged in 1a05104. |
|
This pull request has been reverted by 625bc40. |
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
Summary: Pull Request resolved: pytorch#49364 We had a local `Tensor` when we only needed a `const Tensor&`. ghstack-source-id: 118624595 Test Plan: Internal benchmark. Reviewed By: hlu1 Differential Revision: D25544731 fbshipit-source-id: 7b9656d0371ab65a6313cb0ad4aa1df707884c1c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We had a local
Tensorwhen we only needed aconst Tensor&.Differential Revision: D25544731
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!