[PyTorch] Use .sizes() isntead of .size() in cat_serial_kernel_impl #49371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As with previous diff, .sizes() is strictly more efficient. Differential Revision: [D25546409](https://our.internmc.facebook.com/intern/diff/D25546409/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25546409/)! [ghstack-poisoned]
This was referenced Dec 14, 2020
swolchok
added a commit
that referenced
this pull request
Dec 14, 2020
As with previous diff, .sizes() is strictly more efficient. Differential Revision: [D25546409](https://our.internmc.facebook.com/intern/diff/D25546409/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25546409/)! ghstack-source-id: 118565553 Pull Request resolved: #49371
💊 CI failures summary and remediationsAs of commit 8abbcf1 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 22 times. |
…rnel_impl" As with previous diff, .sizes() is strictly more efficient. Differential Revision: [D25546409](https://our.internmc.facebook.com/intern/diff/D25546409/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25546409/)! [ghstack-poisoned]
…rnel_impl" As with previous diff, .sizes() is strictly more efficient. Differential Revision: [D25546409](https://our.internmc.facebook.com/intern/diff/D25546409/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25546409/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Dec 15, 2020
Pull Request resolved: #49371 As with previous diff, .sizes() is strictly more efficient. ghstack-source-id: 118627223 Differential Revision: [D25546409](https://our.internmc.facebook.com/intern/diff/D25546409/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25546409/)!
|
This pull request has been merged in 953f992. |
|
This pull request has been reverted by 52b3775. |
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
…ytorch#49371) Summary: Pull Request resolved: pytorch#49371 As with previous diff, .sizes() is strictly more efficient. ghstack-source-id: 118627223 Test Plan: internal benchmark Differential Revision: D25546409 fbshipit-source-id: 196034716b6e11efda1ec8cb1e0fce7732d73eb4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
As with previous diff, .sizes() is strictly more efficient.
Differential Revision: D25546409
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!