[PyTorch] Make tls_local_dispatch_key_set inlineable (reapply) #49412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FLAGS_disable_variable_dispatch had to go, but it looks like the only user was some benchmarks anyway. Differential Revision: [D25547962](https://our.internmc.facebook.com/intern/diff/D25547962/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25547962/)! [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 09a59b9 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 9 times. |
This was referenced Dec 15, 2020
swolchok
added a commit
that referenced
this pull request
Dec 15, 2020
FLAGS_disable_variable_dispatch had to go, but it looks like the only user was some benchmarks anyway. Differential Revision: [D25547962](https://our.internmc.facebook.com/intern/diff/D25547962/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25547962/)! ghstack-source-id: 118624599 Pull Request resolved: #49412
|
Yeah.... Scott, I'm pretty sure this error is why it wasn't inlined on Windows. Maybe that just means we should only inline on Linux though. |
… inlineable (reapply)" FLAGS_disable_variable_dispatch had to go, but it looks like the only user was some benchmarks anyway. Differential Revision: [D25547962](https://our.internmc.facebook.com/intern/diff/D25547962/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25547962/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Dec 16, 2020
Pull Request resolved: #49412 FLAGS_disable_variable_dispatch had to go, but it looks like the only user was some benchmarks anyway. ghstack-source-id: 118669590 Differential Revision: [D25547962](https://our.internmc.facebook.com/intern/diff/D25547962/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25547962/)!
Codecov Report
@@ Coverage Diff @@
## gh/swolchok/48/base #49412 +/- ##
=======================================================
- Coverage 80.57% 80.56% -0.01%
=======================================================
Files 1875 1875
Lines 202706 202702 -4
=======================================================
- Hits 163321 163309 -12
- Misses 39385 39393 +8 |
|
This pull request has been merged in 6f928a4. |
|
This pull request has been reverted by 19dc5e9. |
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
…ch#49412) Summary: Pull Request resolved: pytorch#49412 FLAGS_disable_variable_dispatch had to go, but it looks like the only user was some benchmarks anyway. ghstack-source-id: 118669590 Test Plan: Small (order of 0.1% improvement) on Internal benchmarks. Wait for GitHub CI since this was reverted before due to CI break Reviewed By: ezyang Differential Revision: D25547962 fbshipit-source-id: 58424b1da230fdc5d27349af762126a5512fce43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
FLAGS_disable_variable_dispatch had to go, but it looks like the only user was some benchmarks anyway.
Differential Revision: D25547962
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!