Fix warning when running scripts/build_ios.sh #49457
Conversation
💊 CI failures summary and remediationsAs of commit 6f87223 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 37 times. |
Codecov Report
@@ Coverage Diff @@
## master #49457 +/- ##
==========================================
- Coverage 80.68% 80.68% -0.01%
==========================================
Files 1904 1904
Lines 206555 206555
==========================================
- Hits 166667 166658 -9
- Misses 39888 39897 +9 |
skyline75489
changed the title
| add_definitions("-mfpu=neon-fp16") | ||
| add_definitions("-arch" ${IOS_ARCH}) |
There was a problem hiding this comment.
I found that XNNPACK has more comprehensive flag configuration https://github.com/google/XNNPACK/blob/02bb42942798fdd0cf444b0fc90b6e20b847688f/CMakeLists.txt#L2729. Not sure if we want to use this, too.
There was a problem hiding this comment.
To explain this change. -mfpu=neon-fp16 is only supported on armv7 devices (iPhone 4, 4s, iPhone 5, 5c, 5s). Nowadays we would normally target arm64 which -march=armv8.2-a+fp16 and related should be used.
mrshenli
added
module: build
Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com>
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
cmake implicitly converting 'string' to 'STRING' typeclang: warning: argument unused during compilation: '-mfpu=neon-fp16' [-Wunused-command-line-argument]