Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MKL builds on Ubuntu #50212

Closed
wants to merge 1 commit into from
Closed

Fix MKL builds on Ubuntu #50212

wants to merge 1 commit into from

Conversation

antocuni
Copy link
Contributor

@antocuni antocuni commented Jan 7, 2021

This fixes #50211

@antocuni
the purpose of this if is to ensure that you pass --no-as-needed to t…
e2d806d 
…he linker, but if CMAKE_SHARED_FLAGS by chance contains --as-needed the latter overrides the former. By passing it after, we ensure we override the behavior
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 7, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit e2d806d (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

1 job timed out:

  • pytorch_linux_bionic_py3_8_gcc9_coverage_test1

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 5 times.

@gchanan gchanan requested a review from walterddr January 8, 2021 18:43
@gchanan gchanan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 8, 2021
facebook-github-bot
facebook-github-bot reviewed Jan 8, 2021
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@walterddr walterddr mentioned this pull request Jan 8, 2021
Closed
facebook-github-bot
facebook-github-bot reviewed Jan 8, 2021
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@walterddr merged this pull request in 8f31621.

hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 14, 2021
@antocuni
Fix MKL builds on Ubuntu (pytorch#50212)
f0d5b80 
Summary:
This fixes pytorch#50211

Pull Request resolved: pytorch#50212

Reviewed By: janeyx99

Differential Revision: D25850876

Pulled By: walterddr

fbshipit-source-id: be138db3ae370c45f5fbf3af486cf8b32518df87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@walterddr walterddr walterddr approved these changes

Assignees
No one assigned
Labels
cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build broken on ubuntu due to MKL symbols not found
5 participants
@antocuni @facebook-github-bot @walterddr @gchanan @pytorchbot