Enable fast pass tensor_fill for single element complex tensors #50383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
anjali411
added a commit
that referenced
this pull request
Jan 11, 2021
ghstack-source-id: 6bda69d05f384b92f4914abdd8a5c70a890206f3 Pull Request resolved: #50383
💊 CI failures summary and remediationsAs of commit 2fbe2cb (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 3 times. |
anjali411
changed the title
zasdfgbnm
approved these changes
Jan 12, 2021
mruberry
reviewed
Jan 12, 2021
| @@ -18,7 +18,7 @@ Tensor& fill_out(Tensor& self, Scalar value) { | |||
| self.copy_(out); | |||
| return self; | |||
| } | |||
| if (self.device() == at::kCPU && self.numel() == 1 && !self.is_complex() && !value.isComplex()) { | |||
| if (self.device() == at::kCPU && self.numel() == 1) { | |||
There was a problem hiding this comment.
Is this path actually tested somewhere?
|
The code changes look good -- is this path actually tested, though? I was looking through test_tensor_creation_ops.py and this may need to add a test for filling tensors with scalars of different dtypes. |
|
@anjali411 merged this pull request in 5834438. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D25879881