Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Update repeat_interleave symbolic #54312

Merged

Conversation

shubhambhokare1
Copy link
Collaborator

Add implementation for cases when

  • interleaving happens along dim which consist of dynamic axes

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 19, 2021

💊 CI failures summary and remediations

As of commit 3e193da (more details on the Dr. CI page):


  • 7/7 failures introduced in this PR

🕵️ 7 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_test (1/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Apr 05 22:40:30 sccache: error: couldn't connect to server
Apr 05 22:40:30 +++ eval 'extract_trap_cmd '
Apr 05 22:40:30 ++++ extract_trap_cmd
Apr 05 22:40:30 ++++ printf '%s\n' ''
Apr 05 22:40:30 +++ printf '%s\n' cleanup
Apr 05 22:40:30 ++ trap -- '
Apr 05 22:40:30 cleanup' EXIT
Apr 05 22:40:30 ++ [[ pytorch-xla-linux-bionic-py3.6-clang9-test != *pytorch-win-* ]]
Apr 05 22:40:30 ++ which sccache
Apr 05 22:40:30 ++ sccache --stop-server
Apr 05 22:40:30 Stopping sccache server...
Apr 05 22:40:30 sccache: error: couldn't connect to server
Apr 05 22:40:30 sccache: caused by: Connection refused (os error 111)
Apr 05 22:40:30 ++ true
Apr 05 22:40:30 ++ rm /var/lib/jenkins/sccache_error.log
Apr 05 22:40:30 ++ [[ pytorch-xla-linux-bionic-py3.6-clang9-test == *rocm* ]]
Apr 05 22:40:30 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log
Apr 05 22:40:30 ++ SCCACHE_IDLE_TIMEOUT=1200
Apr 05 22:40:30 ++ RUST_LOG=sccache::server=error
Apr 05 22:40:30 ++ sccache --start-server
Apr 05 22:40:30 sccache: Starting the server...
Apr 05 22:40:31 ++ sccache --zero-stats

See CircleCI build pytorch_cpp_doc_build (2/7)

Step: "Doc Build and Push" (full log | diagnosis details | 🔁 rerun)

Apr 05 22:10:33 Makefile:27: recipe for target 'html' failed
Apr 05 22:10:29 Installing collected packages: pytz, MarkupSafe, sphinxcontrib-serializinghtml, sphinxcontrib-qthelp, sphinxcontrib-jsmath, sphinxcontrib-htmlhelp, sphinxcontrib-devhelp, sphinxcontrib-applehelp, soupsieve, snowballstemmer, Pygments, Jinja2, imagesize, docutils, babel, alabaster, sphinx, beautifulsoup4, lxml, bs4, breathe, pytorch-sphinx-theme, exhale
Apr 05 22:10:32   Running setup.py develop for pytorch-sphinx-theme
Apr 05 22:10:32 Successfully installed Jinja2-2.11.3 MarkupSafe-1.1.1 Pygments-2.8.1 alabaster-0.7.12 babel-2.9.0 beautifulsoup4-4.9.3 breathe-4.25.0 bs4-0.0.1 docutils-0.17 exhale-0.2.3 imagesize-1.2.0 lxml-4.6.3 pytorch-sphinx-theme pytz-2021.1 snowballstemmer-2.1.0 soupsieve-2.2.1 sphinx-3.1.2 sphinxcontrib-applehelp-1.0.2 sphinxcontrib-devhelp-1.0.2 sphinxcontrib-htmlhelp-1.0.3 sphinxcontrib-jsmath-1.0.1 sphinxcontrib-qthelp-1.0.3 sphinxcontrib-serializinghtml-1.1.4
Apr 05 22:10:32 ++ make VERBOSE=1 html -j
Apr 05 22:10:33 Running Sphinx v3.1.2
Apr 05 22:10:33 
Apr 05 22:10:33 Encoding error:
Apr 05 22:10:33 'ascii' codec can't decode byte 0xc2 in position 69: ordinal not in range(128)
Apr 05 22:10:33 The full traceback has been saved in /tmp/sphinx-err-k3s0vkvd.log, if you want to report the issue to the developers.
Apr 05 22:10:33 make: *** [html] Error 2
Apr 05 22:10:33 Makefile:27: recipe for target 'html' failed


Exited with code exit status 2

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_jit_legacy_test (3/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Apr 05 22:01:45 sccache: error: couldn't connect to server
Apr 05 22:01:45 +++ eval 'extract_trap_cmd '
Apr 05 22:01:45 ++++ extract_trap_cmd
Apr 05 22:01:45 ++++ printf '%s\n' ''
Apr 05 22:01:45 +++ printf '%s\n' cleanup
Apr 05 22:01:45 ++ trap -- '
Apr 05 22:01:45 cleanup' EXIT
Apr 05 22:01:45 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-jit_legacy-test != *pytorch-win-* ]]
Apr 05 22:01:45 ++ which sccache
Apr 05 22:01:45 ++ sccache --stop-server
Apr 05 22:01:45 Stopping sccache server...
Apr 05 22:01:45 sccache: error: couldn't connect to server
Apr 05 22:01:45 sccache: caused by: Connection refused (os error 111)
Apr 05 22:01:45 ++ true
Apr 05 22:01:45 ++ rm /var/lib/jenkins/sccache_error.log
Apr 05 22:01:45 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-jit_legacy-test == *rocm* ]]
Apr 05 22:01:45 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log
Apr 05 22:01:45 ++ SCCACHE_IDLE_TIMEOUT=1200
Apr 05 22:01:45 ++ RUST_LOG=sccache::server=error
Apr 05 22:01:45 ++ sccache --start-server
Apr 05 22:01:45 sccache: Starting the server...
Apr 05 22:01:45 ++ sccache --zero-stats

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (4/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Apr 05 22:02:14 sccache: error: couldn't connect to server
Apr 05 22:02:14 +++ eval 'extract_trap_cmd '
Apr 05 22:02:14 ++++ extract_trap_cmd
Apr 05 22:02:14 ++++ printf '%s\n' ''
Apr 05 22:02:14 +++ printf '%s\n' cleanup
Apr 05 22:02:14 ++ trap -- '
Apr 05 22:02:14 cleanup' EXIT
Apr 05 22:02:14 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-test != *pytorch-win-* ]]
Apr 05 22:02:14 ++ which sccache
Apr 05 22:02:14 ++ sccache --stop-server
Apr 05 22:02:14 Stopping sccache server...
Apr 05 22:02:14 sccache: error: couldn't connect to server
Apr 05 22:02:14 sccache: caused by: Connection refused (os error 111)
Apr 05 22:02:14 ++ true
Apr 05 22:02:14 ++ rm /var/lib/jenkins/sccache_error.log
Apr 05 22:02:14 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-test == *rocm* ]]
Apr 05 22:02:14 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log
Apr 05 22:02:14 ++ SCCACHE_IDLE_TIMEOUT=1200
Apr 05 22:02:14 ++ RUST_LOG=sccache::server=error
Apr 05 22:02:14 ++ sccache --start-server
Apr 05 22:02:14 sccache: Starting the server...
Apr 05 22:02:14 ++ sccache --zero-stats

See CircleCI build pytorch_doc_test (5/7)

Step: "Doc test" (full log | diagnosis details | 🔁 rerun)

Apr 05 22:05:10 sccache: error: couldn't connect to server
Apr 05 22:05:10 ++++ eval 'extract_trap_cmd '
Apr 05 22:05:10 +++++ extract_trap_cmd
Apr 05 22:05:10 +++++ printf '%s\n' ''
Apr 05 22:05:10 ++++ printf '%s\n' cleanup
Apr 05 22:05:10 +++ trap -- '
Apr 05 22:05:10 cleanup' EXIT
Apr 05 22:05:10 +++ [[ pytorch-linux-xenial-py3.6-gcc5.4-build != *pytorch-win-* ]]
Apr 05 22:05:10 +++ which sccache
Apr 05 22:05:10 +++ sccache --stop-server
Apr 05 22:05:10 Stopping sccache server...
Apr 05 22:05:10 sccache: error: couldn't connect to server
Apr 05 22:05:10 sccache: caused by: Connection refused (os error 111)
Apr 05 22:05:10 +++ true
Apr 05 22:05:10 +++ rm /var/lib/jenkins/sccache_error.log
Apr 05 22:05:10 +++ [[ pytorch-linux-xenial-py3.6-gcc5.4-build == *rocm* ]]
Apr 05 22:05:10 +++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log
Apr 05 22:05:10 +++ SCCACHE_IDLE_TIMEOUT=1200
Apr 05 22:05:10 +++ RUST_LOG=sccache::server=error
Apr 05 22:05:10 +++ sccache --start-server
Apr 05 22:05:10 sccache: Starting the server...
Apr 05 22:05:10 +++ sccache --zero-stats

See CircleCI build pytorch_linux_backward_compatibility_check_test (6/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Apr 05 22:01:41 sccache: error: couldn't connect to server
Apr 05 22:01:41 +++ eval 'extract_trap_cmd '
Apr 05 22:01:41 ++++ extract_trap_cmd
Apr 05 22:01:41 ++++ printf '%s\n' ''
Apr 05 22:01:41 +++ printf '%s\n' cleanup
Apr 05 22:01:41 ++ trap -- '
Apr 05 22:01:41 cleanup' EXIT
Apr 05 22:01:41 ++ [[ pytorch-linux-backward-compatibility-check-test != *pytorch-win-* ]]
Apr 05 22:01:41 ++ which sccache
Apr 05 22:01:41 ++ sccache --stop-server
Apr 05 22:01:41 Stopping sccache server...
Apr 05 22:01:41 sccache: error: couldn't connect to server
Apr 05 22:01:41 sccache: caused by: Connection refused (os error 111)
Apr 05 22:01:41 ++ true
Apr 05 22:01:41 ++ rm /var/lib/jenkins/sccache_error.log
Apr 05 22:01:41 ++ [[ pytorch-linux-backward-compatibility-check-test == *rocm* ]]
Apr 05 22:01:41 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log
Apr 05 22:01:41 ++ SCCACHE_IDLE_TIMEOUT=1200
Apr 05 22:01:41 ++ RUST_LOG=sccache::server=error
Apr 05 22:01:41 ++ sccache --start-server
Apr 05 22:01:41 sccache: Starting the server...
Apr 05 22:01:41 ++ sccache --zero-stats

See CircleCI build pytorch_python_doc_build (7/7)

Step: "Doc Build and Push" (full log | diagnosis details | 🔁 rerun)

Apr 05 22:05:10 Makefile:38: recipe for target 'html' failed
Apr 05 22:05:09     from docutils.writers.latex2e import Babel
Apr 05 22:05:09   File "/opt/conda/lib/python3.6/site-packages/docutils/writers/latex2e/__init__.py", line 575, in <module>
Apr 05 22:05:09     for line in fp:
Apr 05 22:05:09   File "/opt/conda/lib/python3.6/encodings/ascii.py", line 26, in decode
Apr 05 22:05:09     return codecs.ascii_decode(input, self.errors)[0]
Apr 05 22:05:09 UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 69: ordinal not in range(128)
Apr 05 22:05:09 
Apr 05 22:05:09 Encoding error:
Apr 05 22:05:09 'ascii' codec can't decode byte 0xc2 in position 69: ordinal not in range(128)
Apr 05 22:05:09 The full traceback has been saved in /tmp/sphinx-err-ak63e7h4.log, if you want to report the issue to the developers.
Apr 05 22:05:10 Makefile:38: recipe for target 'html' failed
Apr 05 22:05:10 make: *** [html] Error 2
Apr 05 22:05:10 ++ code=2
Apr 05 22:05:10 ++ '[' 2 -ne 0 ']'
Apr 05 22:05:10 ++ set +x
Apr 05 22:05:10 =========================
Apr 05 22:05:10 =========================
Apr 05 22:05:10 Docs build failed. If the failure is not clear, scan back in the log
Apr 05 22:05:10 for any WARNINGS or for the line build finished with problems
Apr 05 22:05:10 (tried to echo the WARNINGS above the ==== line)
Apr 05 22:05:10 =========================

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

# }

# Loop conditions
loop_condition = g.op("Constant", value_t=torch.tensor(1))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if it's possible to create bool constant directly?

@BowenBao
Copy link
Collaborator

Thanks, looks good overall, have some questions regarding details

@BowenBao BowenBao merged commit 7cd2fe4 into pytorch:onnx_ms_1 Apr 8, 2021
BowenBao pushed a commit to BowenBao/pytorch that referenced this pull request Apr 15, 2021
Add implementation for cases when
- interleaving happens along dim which consist of dynamic axes
BowenBao pushed a commit that referenced this pull request Apr 15, 2021
Add implementation for cases when
- interleaving happens along dim which consist of dynamic axes

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Apr 15, 2021
Add implementation for cases when
- interleaving happens along dim which consist of dynamic axes

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Apr 16, 2021
Add implementation for cases when
- interleaving happens along dim which consist of dynamic axes

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Apr 16, 2021
Add implementation for cases when
- interleaving happens along dim which consist of dynamic axes

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Apr 21, 2021
Summary:
Pull Request resolved: #56165

Add implementation for cases when
- interleaving happens along dim which consist of dynamic axes

Test Plan: Imported from OSS

Reviewed By: pbelevich

Differential Revision: D27866137

Pulled By: SplitInfinity

fbshipit-source-id: 7fef1b2c614f2e24a677b7ca0886bb37bd0ab479
heitorschueroff pushed a commit that referenced this pull request Apr 21, 2021
Summary:
Pull Request resolved: #56165

Add implementation for cases when
- interleaving happens along dim which consist of dynamic axes

Test Plan: Imported from OSS

Reviewed By: pbelevich

Differential Revision: D27866137

Pulled By: SplitInfinity

fbshipit-source-id: 7fef1b2c614f2e24a677b7ca0886bb37bd0ab479
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
Summary:
Pull Request resolved: pytorch#56165

Add implementation for cases when
- interleaving happens along dim which consist of dynamic axes

Test Plan: Imported from OSS

Reviewed By: pbelevich

Differential Revision: D27866137

Pulled By: SplitInfinity

fbshipit-source-id: 7fef1b2c614f2e24a677b7ca0886bb37bd0ab479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants