-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Fix onnx/constant_fold.cpp compilation on Windows (#55770) #56167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VC++ does not recognize `or` as a valid operator. This breaks the build under `Debug` configuration. [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 98d0758 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Apr 15, 2021
VC++ does not recognize `or` as a valid operator. This breaks the build under `Debug` configuration. [ghstack-poisoned]
VC++ does not recognize `or` as a valid operator. This breaks the build under `Debug` configuration. [ghstack-poisoned]
VC++ does not recognize `or` as a valid operator. This breaks the build under `Debug` configuration. [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/BowenBao/43/base #56167 +/- ##
====================================================
Coverage 77.01% 77.01%
====================================================
Files 1917 1917
Lines 190280 190280
====================================================
+ Hits 146547 146548 +1
+ Misses 43733 43732 -1 |
@SplitInfinity merged this pull request in a31fd7f. |
heitorschueroff
pushed a commit
that referenced
this pull request
Apr 21, 2021
Summary: Pull Request resolved: #56167 VC++ does not recognize `or` as a valid operator. This breaks the build under `Debug` configuration. Test Plan: Imported from OSS Reviewed By: pbelevich Differential Revision: D27866143 Pulled By: SplitInfinity fbshipit-source-id: 490cee57b9762170ce02a6f73130772a3542e76d
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
…torch#56167) Summary: Pull Request resolved: pytorch#56167 VC++ does not recognize `or` as a valid operator. This breaks the build under `Debug` configuration. Test Plan: Imported from OSS Reviewed By: pbelevich Differential Revision: D27866143 Pulled By: SplitInfinity fbshipit-source-id: 490cee57b9762170ce02a6f73130772a3542e76d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
VC++ does not recognize
or
as a valid operator. This breaks the build underDebug
configuration.Differential Revision: D27866143