Skip to content

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Apr 15, 2021

Stack from ghstack:

VC++ does not recognize or as a valid operator. This breaks the build under Debug configuration.

Differential Revision: D27866143

VC++ does not recognize `or` as a valid operator. This breaks the build under `Debug` configuration.

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue cla signed labels Apr 15, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 15, 2021

💊 CI failures summary and remediations

As of commit 98d0758 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

VC++ does not recognize `or` as a valid operator. This breaks the build under `Debug` configuration.

[ghstack-poisoned]
VC++ does not recognize `or` as a valid operator. This breaks the build under `Debug` configuration.

[ghstack-poisoned]
VC++ does not recognize `or` as a valid operator. This breaks the build under `Debug` configuration.

[ghstack-poisoned]
@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

Merging #56167 (98d0758) into gh/BowenBao/43/base (04ca4cd) will increase coverage by 0.00%.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           gh/BowenBao/43/base   #56167   +/-   ##
====================================================
  Coverage                77.01%   77.01%           
====================================================
  Files                     1917     1917           
  Lines                   190280   190280           
====================================================
+ Hits                    146547   146548    +1     
+ Misses                   43733    43732    -1     

@facebook-github-bot
Copy link
Contributor

@SplitInfinity merged this pull request in a31fd7f.

heitorschueroff pushed a commit that referenced this pull request Apr 21, 2021
Summary:
Pull Request resolved: #56167

VC++ does not recognize `or` as a valid operator. This breaks the build under `Debug` configuration.

Test Plan: Imported from OSS

Reviewed By: pbelevich

Differential Revision: D27866143

Pulled By: SplitInfinity

fbshipit-source-id: 490cee57b9762170ce02a6f73130772a3542e76d
@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/43/head branch April 24, 2021 14:16
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
…torch#56167)

Summary:
Pull Request resolved: pytorch#56167

VC++ does not recognize `or` as a valid operator. This breaks the build under `Debug` configuration.

Test Plan: Imported from OSS

Reviewed By: pbelevich

Differential Revision: D27866143

Pulled By: SplitInfinity

fbshipit-source-id: 490cee57b9762170ce02a6f73130772a3542e76d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants