Address feedback from #66673 #66905
Closed
Address feedback from #66673 #66905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify both `build_generates_artifacts` and `exclude_tests` properties
malfet
requested review from
driazati,
janeyx99,
seemethere and
zhouzhuojie
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit ffbcd0c (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
malfet
changed the title
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
seemethere
approved these changes
Oct 19, 2021
Polydynamical
approved these changes
Oct 20, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 20, 2021
Summary: Specify both `build_generates_artifacts` and `exclude_tests` properties as suggested in #66673 (review) Pull Request resolved: #66905 Reviewed By: seemethere Differential Revision: D31779742 Pulled By: malfet fbshipit-source-id: 21f5543f3b767f38132be8c7e163455f39ff893f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify both
build_generates_artifactsandexclude_testsproperties as suggested in #66673 (review)