[jit] Reclaim some binary size. #68038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 0345181 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Nov 8, 2021
facebook-github-bot
added
the
oncall: jit
zhxchen17
added a commit
that referenced
this pull request
Nov 8, 2021
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) ghstack-source-id: 142764417 Pull Request resolved: #68038
zhxchen17
requested review from
gmagogsfm,
iseeyuan,
qihqi and
tugsbayasgalan
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) [ghstack-poisoned]
This was referenced Nov 10, 2021
qihqi
approved these changes
Nov 10, 2021
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
This was referenced Dec 6, 2021
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
This was referenced Dec 17, 2021
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
This was referenced Dec 20, 2021
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller. Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619/) Differential Revision: [D32264619](https://our.internmc.facebook.com/intern/diff/D32264619) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Replace const std::function& to c10::function_ref because the former uses type erasure and adds 5-10 KB size overhead and adds another level of indirection to call the underlying functions. In contrast a non-owning c10::function_ref will just compile down to a raw function pointer which should be much smaller.
Differential Revision: D32264619
Differential Revision: D32264619