[jit][edge] Migrate TupleType to DynamicType on mobile. #70205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit d332d58 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 linux-xenial-py3.7-gcc5.4 / test (docs_test, 1, 1, linux.2xlarge) |
Test | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
facebook-github-bot
added
cla signed
oncall: jit
This was referenced Dec 20, 2021
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places: 1. Type parser which produces the Type constants. 2. IValue::type() which returns reflected Type from IValues. 3. Helper functions to construct the container value. 4. Typechecks which test whether a type instance is a particular container type. Differential Revision: [D33176925](https://our.internmc.facebook.com/intern/diff/D33176925/) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Use DynamicType instead of TupleType all over the place in Lite Interpreter. Namely we need to modify the following places:
Differential Revision: D33176925