[jit][edge] Reclaim some binary size. #70255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should give us 1-2KB back on mobile due to removal of redundant container copy and shared_ptr decrement. Differential Revision: [D33230514](https://our.internmc.facebook.com/intern/diff/D33230514/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit e83c5f6 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: jit
This was referenced Dec 21, 2021
Should give us 1-2KB back on mobile due to removal of redundant container copy and shared_ptr decrement. Differential Revision: [D33230514](https://our.internmc.facebook.com/intern/diff/D33230514/) [ghstack-poisoned]
zhxchen17
added a commit
that referenced
this pull request
Dec 21, 2021
Pull Request resolved: #70255 Should give us 1-2KB back on mobile due to removal of redundant container copy and shared_ptr decrement. ghstack-source-id: 146109878 Differential Revision: [D33230514](https://our.internmc.facebook.com/intern/diff/D33230514/)
Should give us 1-2KB back on mobile due to removal of redundant container copy and shared_ptr decrement. Differential Revision: [D33230514](https://our.internmc.facebook.com/intern/diff/D33230514/) [ghstack-poisoned]
zhxchen17
added a commit
that referenced
this pull request
Dec 24, 2021
Pull Request resolved: #70255 Should give us 1-2KB back on mobile due to removal of redundant container copy and shared_ptr decrement. ghstack-source-id: 146227585 Differential Revision: [D33230514](https://our.internmc.facebook.com/intern/diff/D33230514/)
Should give us 1-2KB back on mobile due to removal of redundant container copy and shared_ptr decrement. Differential Revision: [D33230514](https://our.internmc.facebook.com/intern/diff/D33230514/) [ghstack-poisoned]
Should give us 1-2KB back on mobile due to removal of redundant container copy and shared_ptr decrement. Differential Revision: [D33230514](https://our.internmc.facebook.com/intern/diff/D33230514/) [ghstack-poisoned]
Should give us 1-2KB back on mobile due to removal of redundant container copy and shared_ptr decrement. Differential Revision: [D33230514](https://our.internmc.facebook.com/intern/diff/D33230514/) [ghstack-poisoned]
Should give us 1-2KB back on mobile due to removal of redundant container copy and shared_ptr decrement. Differential Revision: [D33230514](https://our.internmc.facebook.com/intern/diff/D33230514/) [ghstack-poisoned]
Should give us 1-2KB back on mobile due to removal of redundant container copy and shared_ptr decrement. Differential Revision: [D33230514](https://our.internmc.facebook.com/intern/diff/D33230514/) [ghstack-poisoned]
Should give us 1-2KB back on mobile due to removal of redundant container copy and shared_ptr decrement. Differential Revision: [D33230514](https://our.internmc.facebook.com/intern/diff/D33230514/) [ghstack-poisoned]
qihqi
approved these changes
Jan 22, 2022
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Should give us 1-2KB back on mobile due to removal of redundant container copy and shared_ptr decrement.
Differential Revision: D33230514