[jit][edge] Use dynamic type instead of union types for schema parsers. #70509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 2954869 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 linux-xenial-py3.7-gcc5.4 / test (docs_test, 1, 1, linux.2xlarge) |
Test | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
facebook-github-bot
added
the
oncall: jit
This was referenced Dec 29, 2021
…hema parsers." TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/) [ghstack-poisoned]
zhxchen17
added a commit
that referenced
this pull request
Dec 29, 2021
Pull Request resolved: #70509 TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. ghstack-source-id: 146337362 Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/)
…hema parsers." TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/) [ghstack-poisoned]
zhxchen17
added a commit
that referenced
this pull request
Dec 30, 2021
Pull Request resolved: #70509 TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. ghstack-source-id: 146351141 Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/)
…hema parsers." TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/) [ghstack-poisoned]
zhxchen17
added a commit
that referenced
this pull request
Jan 4, 2022
Pull Request resolved: #70509 TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. ghstack-source-id: 146487894 Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/)
iseeyuan
approved these changes
Jan 5, 2022
…hema parsers." TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/) [ghstack-poisoned]
zhxchen17
added a commit
that referenced
this pull request
Jan 5, 2022
Pull Request resolved: #70509 TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. ghstack-source-id: 146564654 Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/)
…hema parsers." TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/) [ghstack-poisoned]
zhxchen17
added a commit
that referenced
this pull request
Jan 7, 2022
Pull Request resolved: #70509 TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. ghstack-source-id: 146670519 Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/)
…hema parsers." TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/) [ghstack-poisoned]
…hema parsers." TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/) [ghstack-poisoned]
zhxchen17
added a commit
that referenced
this pull request
Jan 8, 2022
Pull Request resolved: #70509 TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. ghstack-source-id: 146727336 Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/)
…hema parsers." TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/) [ghstack-poisoned]
…hema parsers." TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/) [ghstack-poisoned]
zhxchen17
added a commit
that referenced
this pull request
Jan 8, 2022
Pull Request resolved: #70509 TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. ghstack-source-id: 146735644 Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/)
…hema parsers." TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/) [ghstack-poisoned]
zhxchen17
added a commit
that referenced
this pull request
Jan 11, 2022
Pull Request resolved: #70509 TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase. ghstack-source-id: 146818621 Differential Revision: [D33306737](https://our.internmc.facebook.com/intern/diff/D33306737/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
TypeFactory will construct DynamicType when building on Edge platforms. We use this facility to make FunctionSchema return DynamicType all the time for OptionalType. We don't explicitly use DynamicTypeFactory everywhere because that requires too many changes and will split the entire aten codebase.
Differential Revision: D33306737