Emit std::string instead of c10::string_view for Lazy IR class #74029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 46df399 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
wconstab
reviewed
Mar 10, 2022
tools/codegen/dest/lazy_ir.py
Outdated
| @@ -105,7 +105,7 @@ def gen(self, f: Union[NativeFunctionsGroup, NativeFunction]) -> List[str]: | |||
| node_ctor_args = ", ".join([f"const {i.cpp_type()}& {i.name}" for i in all_types]) | |||
| scalar_initializers = ",\n ".join([f"{t.name}({t.name})" for t in scalar_types]) | |||
| comma_if_scalar_initializers = ",\n" if len(scalar_initializers) else "" | |||
| scalar_decls = "\n ".join([f"{t.cpp_type()} {t.name};" for t in scalar_types]) | |||
| scalar_decls = "\n ".join([f"std::string {t.name};" if t.cpp_type() == "c10::string_view" else f"{t.cpp_type()} {t.name};" for t in scalar_types]) | |||
There was a problem hiding this comment.
i do want the lint to pass so the line can't be too long
more importantly, i think we should probably fix this inside the data model (basically, t.cpp_type() should probably return std::string for us)
its fine to land this without updating the data model, but it might be easy to do that at the same time.
please TAL at my refactor PR #73939 - it might be easier to modify the data model after that PR lands, or reviewing it might help your understanding of the data model
There was a problem hiding this comment.
I will break the line to pass lint.
Having t.cpp_type() return c10::string_view seems more consistent with other types. E.g. there is another call to cpp_type() at Line 105, which result seems more natural because the parameter is declared as const c10::string_view& and the passed-in variable is also declared as c10::string_view at the callsite in core.
There was a problem hiding this comment.
I will merge the diff now and update it later.
wconstab
approved these changes
Mar 10, 2022
Summary: c10::string_view may be pointing to a temp string, which is not guaranteed to be valid when accessed later, so we store the passed-in string_view into a string.
desertfire
force-pushed
the
binbao/merge2
branch
from
5814817
to
46df399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: c10::string_view may be pointing to a temp string, which is not
guaranteed to be valid when accessed later, so we store the passed-in
string_view into a string.
Fixes #73963