Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #75195 (#82504) #82662

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Revert #75195 (#82504) #82662

merged 1 commit into from
Aug 2, 2022

Conversation

zou3519
Copy link
Contributor

@zou3519 zou3519 commented Aug 2, 2022

This is a short-term fix for a serious regression in functorch
(pytorch/functorch#989).

Additional things this PR does:

Test Plan:

This is a short-term fix for a serious regression in functorch
(pytorch/functorch#989).

Additional things this PR does:
- the out= tests for nn.functional.linear fail after the revert. I added
some xfails. These xfails were present in the original PR (#75195).
- the profiler tests fail on the revert, so I updated the expecttests
for the profiler tests

Test Plan:
- test offline that the functorch regression was fixed
Pull Request resolved: #82504
Approved by: https://github.com/ngimel, https://github.com/ezyang, https://github.com/atalman
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 2, 2022

🔗 Helpful links

❌ 2 New Failures, 3 Pending

As of commit 59d3615 (more details on the Dr. CI page):

Expand to see more
  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / win-vs2019-cpu-py3 / test (default, 2, 2, windows.4xlarge) (1/2)

Step: "Test" (full log | diagnosis details)

2022-08-02T20:03:44.9493006Z RuntimeError: test_ops failed!
2022-08-02T20:03:44.4444046Z 
2022-08-02T20:03:44.4444140Z Generating XML reports...
2022-08-02T20:03:44.4444486Z Generated XML report: test-reports\python-unittest\test_ops\TEST-TestCommonCPU-20220802195215.xml
2022-08-02T20:03:44.4444979Z Generated XML report: test-reports\python-unittest\test_ops\TEST-TestCompositeComplianceCPU-20220802195215.xml
2022-08-02T20:03:44.4445630Z Generated XML report: test-reports\python-unittest\test_ops\TEST-TestMathBitsCPU-20220802195215.xml
2022-08-02T20:03:44.9491787Z Traceback (most recent call last):
2022-08-02T20:03:44.9492124Z   File "run_test.py", line 1077, in <module>
2022-08-02T20:03:44.9492336Z     main()
2022-08-02T20:03:44.9492553Z   File "run_test.py", line 1055, in main
2022-08-02T20:03:44.9492782Z     raise RuntimeError(err_message)
2022-08-02T20:03:44.9493006Z RuntimeError: test_ops failed!
2022-08-02T20:03:45.1995073Z 
2022-08-02T20:03:45.1995540Z (base) C:\actions-runner\_work\pytorch\pytorch\test>if ERRORLEVEL 1 goto fail 
2022-08-02T20:03:45.1997679Z 
2022-08-02T20:03:45.1997880Z (base) C:\actions-runner\_work\pytorch\pytorch\test>exit /b 1 
2022-08-02T20:03:45.2023414Z + cleanup
2022-08-02T20:03:45.2023609Z + retcode=1
2022-08-02T20:03:45.2023773Z + set +x
2022-08-02T20:03:45.2058577Z ##[error]Process completed with exit code 1.
2022-08-02T20:03:45.2373709Z ##[group]Run pytorch/pytorch/.github/actions/get-workflow-job-id@master
2022-08-02T20:03:45.2374040Z with:

See GitHub Actions build pull / win-vs2019-cpu-py3 / test (default, 1, 2, windows.4xlarge) (2/2)

Step: "Test" (full log | diagnosis details)

2022-08-02T20:20:26.0184177Z RuntimeError: test_quantization failed!
2022-08-02T20:20:25.3678531Z Generated XML report: test-reports\python-unittest\test_quantization\TEST-quantization.core.test_quantized_op.TestQuantizedLinear-20220802201346.xml
2022-08-02T20:20:25.3678825Z Generated XML report: test-reports\python-unittest\test_quantization\TEST-quantization.fx.test_numeric_suite_fx.TestFXGraphMatcherModels-20220802201346.xml
2022-08-02T20:20:25.3679143Z Generated XML report: test-reports\python-unittest\test_quantization\TEST-quantization.core.test_quantized_op.TestQNNPackOps-20220802201346.xml
2022-08-02T20:20:25.3679438Z Generated XML report: test-reports\python-unittest\test_quantization\TEST-quantization.dbr.test_quantize_dbr.TestQuantizeDBRModels-20220802201346.xml
2022-08-02T20:20:25.3679749Z Generated XML report: test-reports\python-unittest\test_quantization\TEST-quantization.eager.test_quantize_eager_ptq.TestQuantizeEagerONNXExport-20220802201346.xml
2022-08-02T20:20:26.0182988Z Traceback (most recent call last):
2022-08-02T20:20:26.0183300Z   File "run_test.py", line 1077, in <module>
2022-08-02T20:20:26.0183505Z     main()
2022-08-02T20:20:26.0183725Z   File "run_test.py", line 1055, in main
2022-08-02T20:20:26.0183964Z     raise RuntimeError(err_message)
2022-08-02T20:20:26.0184177Z RuntimeError: test_quantization failed!
2022-08-02T20:20:26.3547359Z 
2022-08-02T20:20:26.3547948Z (base) C:\actions-runner\_work\pytorch\pytorch\test>if ERRORLEVEL 1 goto fail 
2022-08-02T20:20:26.3549774Z 
2022-08-02T20:20:26.3550152Z (base) C:\actions-runner\_work\pytorch\pytorch\test>exit /b 1 
2022-08-02T20:20:26.3577467Z + cleanup
2022-08-02T20:20:26.3577654Z + retcode=1
2022-08-02T20:20:26.3577819Z + set +x
2022-08-02T20:20:26.3614549Z ##[error]Process completed with exit code 1.
2022-08-02T20:20:26.3928244Z ##[group]Run pytorch/pytorch/.github/actions/get-workflow-job-id@master
2022-08-02T20:20:26.3928552Z with:

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@zou3519 zou3519 requested review from atalman and removed request for nikitaved, lezcano, ngimel, IvanYashchuk and mruberry August 2, 2022 19:02
@zou3519
Copy link
Contributor Author

zou3519 commented Aug 2, 2022

This is the cherry-pick of #82504 onto release/1.12

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atalman atalman merged commit efc2d08 into release/1.12 Aug 2, 2022
@lezcano lezcano mentioned this pull request Jan 2, 2023
@github-actions github-actions bot deleted the revert_something_1_12 branch February 18, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants