-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #75195 (#82504) #82662
Merged
Merged
Revert #75195 (#82504) #82662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a short-term fix for a serious regression in functorch (pytorch/functorch#989). Additional things this PR does: - the out= tests for nn.functional.linear fail after the revert. I added some xfails. These xfails were present in the original PR (#75195). - the profiler tests fail on the revert, so I updated the expecttests for the profiler tests Test Plan: - test offline that the functorch regression was fixed Pull Request resolved: #82504 Approved by: https://github.com/ngimel, https://github.com/ezyang, https://github.com/atalman
zou3519
requested review from
mruberry,
ngimel,
lezcano,
nikitaved and
IvanYashchuk
as code owners
August 2, 2022 19:02
🔗 Helpful links
❌ 2 New Failures, 3 PendingAs of commit 59d3615 (more details on the Dr. CI page): Expand to see more
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakagespull / win-vs2019-cpu-py3 / test (default, 2, 2, windows.4xlarge) (1/2)Step: "Test" (full log | diagnosis details)
|
zou3519
requested review from
atalman
and removed request for
nikitaved,
lezcano,
ngimel,
IvanYashchuk and
mruberry
August 2, 2022 19:02
This is the cherry-pick of #82504 onto release/1.12 |
atalman
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a short-term fix for a serious regression in functorch
(pytorch/functorch#989).
Additional things this PR does:
some xfails. These xfails were present in the original PR (Dispatch to mv rather than mm in the case that tensor1.ndim == 1 and tensor2.ndim == 2 #75195).
for the profiler tests
Test Plan:
Pull Request resolved: Revert #75195 #82504
Approved by: https://github.com/ngimel, https://github.com/ezyang, https://github.com/atalman