Skip to content

[functorch] Add more details to the functorch install page #86823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[functorch] Add more details to the functorch install page #86823

wants to merge 3 commits into from

Conversation

zou3519
Copy link
Contributor

@zou3519 zou3519 commented Oct 12, 2022 •
edited
Loading

Stack from ghstack:

Added some details about:

  • pip uninstall functorch being helpful if there are problems
  • pip install functorch still working for BC reasons.

Test Plan:

  • wait for docs preview

@zou3519
[functorch] Add more details to the functorch install page
1ccead1 
Added some details about:
- `pip uninstall functorch` being helpful if there are problems
- `pip install functorch` still working for BC reasons.

Test Plan:
- wait for docs preview

[ghstack-poisoned]
@zou3519 zou3519 mentioned this pull request Oct 12, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 12, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86823

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d407bd1:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@zou3519
Update on "[functorch] Add more details to the functorch install page"
8c59eb3 
Added some details about:
- `pip uninstall functorch` being helpful if there are problems
- `pip install functorch` still working for BC reasons.

Test Plan:
- wait for docs preview

[ghstack-poisoned]
@zou3519
Update on "[functorch] Add more details to the functorch install page"
d407bd1 
Added some details about:
- `pip uninstall functorch` being helpful if there are problems
- `pip install functorch` still working for BC reasons.

Test Plan:
- wait for docs preview

[ghstack-poisoned]
zou3519 added a commit that referenced this pull request Oct 12, 2022
@zou3519
[functorch] Add more details to the functorch install page
a5b1b21 
Added some details about:
- `pip uninstall functorch` being helpful if there are problems
- `pip install functorch` still working for BC reasons.

Test Plan:
- wait for docs preview

ghstack-source-id: 73d1919
Pull Request resolved: #86823
@zou3519 zou3519 requested review from samdow and Chillee October 12, 2022 20:21
@zou3519
Copy link
Contributor Author

zou3519 commented Oct 12, 2022

Preview page over at https://docs-preview.pytorch.org/86823/functorchdocs/install.html

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 13, 2022
@zou3519
Copy link
Contributor Author

zou3519 commented Oct 13, 2022

@pytorchbot merge -f "docs-only change"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

zou3519 added a commit that referenced this pull request Oct 13, 2022
@zou3519
[functorch] Add more details to the functorch install page (#86823)
eb21a4b 
Added some details about:
- `pip uninstall functorch` being helpful if there are problems
- `pip install functorch` still working for BC reasons.

Test Plan:
- wait for docs preview
Pull Request resolved: #86823
Approved by: https://github.com/samdow
This was referenced Oct 13, 2022
Merged
Closed
@github-actions
Copy link
Contributor

Hey @zou3519.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

atalman pushed a commit that referenced this pull request Oct 13, 2022
@zou3519
[functorch] Add more details to the functorch install page (#86823) (#…
51c16f0 
…86903)

Added some details about:
- `pip uninstall functorch` being helpful if there are problems
- `pip install functorch` still working for BC reasons.

Test Plan:
- wait for docs preview
Pull Request resolved: #86823
Approved by: https://github.com/samdow
@malfet malfet mentioned this pull request Nov 23, 2022
Closed
@facebook-github-bot facebook-github-bot deleted the gh/zou3519/553/head branch June 8, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chillee Chillee Awaiting requested review from Chillee

1 more reviewer

@samdow samdow samdow approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zou3519 @pytorchmergebot @samdow