Skip to content

[MPS] Fix the crash in bitwise ops on x86 platforms. #85285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[MPS] Fix the crash in bitwise ops on x86 platforms. #85285

wants to merge 2 commits into from

Conversation

kulinseth
Copy link
Collaborator

Fixes #ISSUE_NUMBER

@kulinseth kulinseth added the ciflow/mps Run MPS tests (subset of trunk) label Sep 19, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 19, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85285

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit f88d39a:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Sep 19, 2022
razarmehr
razarmehr approved these changes Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@razarmehr razarmehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

malfet
malfet approved these changes Sep 19, 2022
View reviewed changes
@malfet
Copy link
Contributor

malfet commented Sep 20, 2022

@pytorchbot merge -f "MPS is green"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

Hey @kulinseth.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@kulinseth @mehtanirav
[MPS] Fix the crash in bitwise ops on x86 platforms. (#85285)
e6d570e 
Fixes #ISSUE_NUMBER

Pull Request resolved: #85285
Approved by: https://github.com/razarmehr, https://github.com/malfet
malfet added a commit that referenced this pull request Oct 19, 2022
@malfet
[MPS] Do not dispatch empty job in bitwise_not
53af3b7 
Follows the pattern from #85285 and returns before computing dispatching an empty metal kernel for bitwise not operation.

Fixes crash when invoked with empty MPS tensor on AMD GPU
@malfet malfet mentioned this pull request Oct 19, 2022
Closed
pytorchmergebot pushed a commit that referenced this pull request Oct 19, 2022
@malfet @pytorchmergebot
[MPS] Do not dispatch empty job in bitwise_not (#87286)
a79e034 
Follows the pattern from #85285 and returns before computing dispatching an empty metal kernel for bitwise not operation.

Fixes crash when invoked with empty MPS tensor on AMD GPU

Pull Request resolved: #87286
Approved by: https://github.com/kulinseth
@malfet malfet mentioned this pull request Oct 20, 2022
Merged
malfet added a commit that referenced this pull request Oct 20, 2022
@malfet
[MPS] Do not dispatch empty job in bitwise_not (#87286)
659e47b 
Follows the pattern from #85285 and returns before computing dispatching an empty metal kernel for bitwise not operation.

Fixes crash when invoked with empty MPS tensor on AMD GPU

Pull Request resolved: #87286
Approved by: https://github.com/kulinseth

(cherry picked from commit a79e034)
malfet added a commit that referenced this pull request Oct 21, 2022
@malfet
[MPS] Do not dispatch empty job in bitwise_not (#87286) (#87427)
05cb998 
Follows the pattern from #85285 and returns before computing dispatching an empty metal kernel for bitwise not operation.

Fixes crash when invoked with empty MPS tensor on AMD GPU

Pull Request resolved: #87286
Approved by: https://github.com/kulinseth

(cherry picked from commit a79e034)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@razarmehr razarmehr razarmehr approved these changes

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) cla signed Merged open source release notes: mps Release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kulinseth @malfet @pytorchmergebot @razarmehr @facebook-github-bot @pytorchbot