Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix SAC #1189

Merged
merged 1 commit into from
May 23, 2023
Merged

[BugFix] Fix SAC #1189

merged 1 commit into from
May 23, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented May 23, 2023 •
edited
Loading

cc @BY571

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2023
BY571
BY571 reviewed May 23, 2023
View reviewed changes
torchrl/objectives/sac.py
delay_qvalue: bool = False,
delay_value: bool = False,
delay_qvalue: bool = True,
delay_value: bool = True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big update wave now on all off policy algos :D I should check IQL as well not sure if I set it as default to True!

@vmoens vmoens added the bug Something isn't working label May 23, 2023
@vmoens vmoens merged commit ae10bb8 into main May 23, 2023
@vmoens vmoens deleted the fix_sac branch May 23, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BY571 BY571 BY571 left review comments

Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmoens @BY571 @facebook-github-bot