Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix nightly tensordict dependency #1302

Merged
merged 1 commit into from
Jun 21, 2023
Merged

[BugFix] Fix nightly tensordict dependency #1302

merged 1 commit into from
Jun 21, 2023

Conversation

skandermoalla
Copy link
Contributor

@skandermoalla skandermoalla commented Jun 21, 2023 •
edited
Loading

Description

Follow-up to #1300. They were swapped.

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 21, 2023
@skandermoalla
Copy link
Contributor Author

I'll try to be a better reviewer next time 😅 #1300

vmoens
vmoens approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha thanks

@vmoens vmoens merged commit e21e4cf into pytorch:main Jun 21, 2023
@vmoens vmoens added bug Something isn't working CI Has to do with CI setup (e.g. wheels & builds, tests...) versioning Versioning change (version number etc) labels Jul 5, 2023
@skandermoalla skandermoalla deleted the patch-3 branch January 31, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CI Has to do with CI setup (e.g. wheels & builds, tests...) CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. versioning Versioning change (version number etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skandermoalla @vmoens @facebook-github-bot