Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix step_mdp() #1334

Merged
merged 6 commits into from
Jun 29, 2023
Merged

[BugFix] Fix step_mdp() #1334

merged 6 commits into from
Jun 29, 2023

Conversation

matteobettini
Copy link
Contributor

Fixes #1333 with solution 1

[WIP] compatibility with nested keys

@matteobettini
fix exclude props
3e7ad57 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 28, 2023
@matteobettini matteobettini marked this pull request as draft June 28, 2023 16:13
@matteobettini
fix
1b73fd0 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
add test
debaa26 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
refactor
e599855 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini matteobettini marked this pull request as ready for review June 28, 2023 16:38
vmoens
vmoens approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I had a go at the docstrings, lmk if that fits what you had in mind

@vmoens vmoens added the bug Something isn't working label Jun 28, 2023
@matteobettini
Copy link
Contributor Author

Good to go for me!

@vmoens vmoens merged commit f6efd77 into pytorch:main Jun 29, 2023
@matteobettini matteobettini deleted the step_mdp_nested branch June 29, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] step_mdp exclude arguments diverge from documentation
3 participants
@matteobettini @vmoens @facebook-github-bot